Fix an issue that wrong z value was used if a new layer is started with wipe tower extrusions. #6980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th wipe tower extrusions.
|
You’re a legend! |
|
It seems we still have a few edge cases to address -_-! |
|
super :P At least this one is fixed - can confirm.... |
|
All non Bambu machine are working fine, but BBL machine's mmu is broken. Need some time to revisit the strategy. |
|
Yeah that code is ridiculously messy :( fantastic thank you for troubleshooting this 👌🏻 |
… be changed after parsing get_last_z_from_gcode
Thanks mate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Description
This update, along with #6934, resolves the remaining issues with the wipe tower.
The GCode class will no longer maintain its own Z height information (m_nominal_z). Instead, it will utilize the Z height from GCodeWriter's m_pos. This approach is less error-prone.
This PR also fixes #6755.
It also enforce "Enable Filament ramming" option
@igiannakas It should fix the wipe tower crashing issue
Screenshots/Recordings/Graphs
Tests