Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows extruder's values on filament's Setting Overrides tab. #6370

Conversation

bernarden
Copy link
Contributor

Description

The idea behind this PR is to make it easier for the users to tweak filament setting overrides i.e. reduce number of times users have to switch between the printer and filament settings to compare the values.

Screenshots/Recordings/Graphs

image
image

image
image

Tests

I've done some manual testing to confirm:

  • Override setting with the same value as extruder is still shown as a change.
  • Resetting unsaved override setting back to original value still works as expected.
  • Override settings are shown correctly on the next load after a save.
  • Extruder settings changes are reflected on Settings Overrides page.

Other

I have discovered a strange behaviour between Filament Settings and Printer Settings windows. On a fresh load of application opening Filament Settings window, navigating to Settings Overrides tab and then closing the window results in Filament tab being opened the next time Filament Settings window is opened. But if you open Printer settings window, navigate to Extruder or Motion ability tabs then the application changes the behaviour to open the last visited tab by the user for both of the windows. I'm mentioning this because when this happens the flow of events in the application changes and causes my change to break until the user changes a tab. As far as I can tell for some reason ConfigOptionsGroup's reload_config method is starting to get called (second time?) after TabFilament's update_filament_overrides_page method which wipes out the values set by me. I'm not sure which is the correct behaviour, so I left that for a discussion here. If last visited tab is the correct behaviour, then I would need help to figure out how to fix this problem.

@SoftFever
Copy link
Owner

Thank you
I like this QoL improvement!

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever SoftFever merged commit 8097bec into SoftFever:main Oct 7, 2024
15 checks passed
@SoftFever
Copy link
Owner

On a fresh load of application opening Filament Settings window, navigating to Settings Overrides tab and then closing the window results in Filament tab being opened the next time Filament Settings window is opened.

This is fine :)

@bernarden bernarden deleted the feature/show-extruder-values-on-filament-overrides-tab branch October 10, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants