Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Shows extruder's values on filament's Setting Overrides tab. (#6370)
# Description The idea behind this PR is to make it easier for the users to tweak filament setting overrides i.e. reduce number of times users have to switch between the printer and filament settings to compare the values. # Screenshots/Recordings/Graphs ![image](https://github.com/user-attachments/assets/7221883e-74cd-4322-847a-800880e59c4b) ![image](https://github.com/user-attachments/assets/6019a0f4-b824-4a76-82e2-00e54f282c12) ![image](https://github.com/user-attachments/assets/75589d5d-0ba5-4c8c-8cb5-e23e67cd9e52) ![image](https://github.com/user-attachments/assets/b38f5000-20e0-48eb-afef-49787c9fec3b) ## Tests I've done some manual testing to confirm: * Override setting with the same value as extruder is still shown as a change. * Resetting unsaved override setting back to original value still works as expected. * Override settings are shown correctly on the next load after a save. * Extruder settings changes are reflected on Settings Overrides page. ## Other I have discovered a strange behaviour between `Filament Settings` and `Printer Settings` windows. On a fresh load of application opening `Filament Settings` window, navigating to `Settings Overrides` tab and then closing the window results in `Filament` tab being opened the next time `Filament Settings` window is opened. But if you open `Printer settings` window, navigate to `Extruder` or `Motion ability` tabs then the application changes the behaviour to open the last visited tab by the user for both of the windows. I'm mentioning this because when this happens the flow of events in the application changes and causes my change to break until the user changes a tab. As far as I can tell for some reason ConfigOptionsGroup's `reload_config` method is starting to get called (second time?) after TabFilament's `update_filament_overrides_page` method which wipes out the values set by me. I'm not sure which is the correct behaviour, so I left that for a discussion here. If last visited tab is the correct behaviour, then I would need help to figure out how to fix this problem.
- Loading branch information