Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoC] Fix style inconsistencies among informative events on IRC and modern layouts #25

Draft
wants to merge 10 commits into
base: sc
Choose a base branch
from
Draft

[PoC] Fix style inconsistencies among informative events on IRC and modern layouts #25

wants to merge 10 commits into from

Commits on Mar 3, 2024

  1. Fix style inconsistencies among mx_TextualEvent, mx_RedactedBody, and… 

    … mx_DecryptionFailureBody on IRC layout

Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    80266a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Replace the color value with clearer one 

    $muted-fg-color can be removed anytime too (see comments by the upstream on each theme variables CSS file).

Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    2a3e4ef View commit details
    Browse the repository at this point in the history

  2. Set the same declarations to mx_RedactedBody 

    Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f6115b8 View commit details
    Browse the repository at this point in the history

  3. Add _EventTile.pcss for setting text color in general way 

    Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    295eca8 View commit details
    Browse the repository at this point in the history

  4. Create EventTile_font mixin and remove redundant files 

    Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f8e4f3d View commit details
    Browse the repository at this point in the history

  5. Update mixin name 

    Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7f32c7c View commit details
    Browse the repository at this point in the history

  6. Specify text color with color property instead of opacity for propert… 

    …ies which start with mx_M

Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    330315c View commit details
    Browse the repository at this point in the history

  7. Import EventTile_line_M at first based on specificity level 

    "mx_EventTile_line [class^="mx_M"]" might appear outside of either mx_EventTile_info or mx_GenericEventListSummary, therefore it should be imported earlier.

Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8eb9404 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Add _DisambiguatedProfile.pcss, applied to RightPanel as well 

    Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    c043a2e View commit details
    Browse the repository at this point in the history

  2. Calculate specificity 

    Signed-off-by: Suguru Hirahara <[email protected]>
    @luixxiul
    luixxiul committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6a42da9 View commit details
    Browse the repository at this point in the history