[PoC] Fix style inconsistencies among informative events on IRC and modern layouts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mx_DecryptionFailureBody on IRC layout Signed-off-by: Suguru Hirahara <[email protected]>
$muted-fg-color can be removed anytime too (see comments by the upstream on each theme variables CSS file). Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
luixxiul
commented
Mar 4, 2024
| @define-mixin consistency__TextEvent { | ||
| @mixin EventTile_line_color; | ||
| @mixin EventTile_line_font; | ||
| @mixin DecryptionFailureBody; |
There was a problem hiding this comment.
The merit of using @mixin as variables is that you can decide the order of rules to be applied as above.
Since the other files just define mixins without actually applying them, it is possible to reduce the possibility of accidental regressions.
luixxiul
force-pushed
the
_sc_consistency__event-style
branch
from
fd4cfa8
to
bb33334
Compare
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
luixxiul
force-pushed
the
_sc_consistency__event-style
branch
from
bb33334
to
7f32c7c
Compare
luixxiul
changed the title
mx_TextualEvent, mx_RedactedBody, and mx_DecryptionFailureBody on IRC layout
luixxiul
force-pushed
the
_sc_consistency__event-style
branch
from
1083d33
to
7f32c7c
Compare
…ies which start with mx_M Signed-off-by: Suguru Hirahara <[email protected]>
"mx_EventTile_line [class^="mx_M"]" might appear outside of either mx_EventTile_info or mx_GenericEventListSummary, therefore it should be imported earlier. Signed-off-by: Suguru Hirahara <[email protected]>
luixxiul
force-pushed
the
_sc_consistency__event-style
branch
from
77712a3
to
8eb9404
Compare
Signed-off-by: Suguru Hirahara <[email protected]>
luixxiul
changed the title
luixxiul
commented
Mar 5, 2024
| /* Applied to IRC, modern layout, and the right panel. Not applied to the | ||
| rest of the layouts. Remove the nested :where() if it is applied to them | ||
| as well. */ | ||
| :where(.mx_RoomView_body:where([data-layout="irc"], [data-layout="group"]), .mx_RightPanel) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Suguru Hirahara <[email protected]>
luixxiul
force-pushed
the
_sc_consistency__event-style
branch
from
088bd2b
to
6a42da9
Compare
SpiritCroc
pushed a commit
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SchildiChat/schildichat-desktop#240
For SchildiChat/schildichat-desktop#241
This PR intends to fix style inconsistencies among
mx_TextualEvent,mx_RedactedBody,mx_DecryptionFailureBody, etc. on IRC layout.As a proof of concept, this PR also intends to demonstrate that using
@mixinas variable that can be imported by importing a CSS file for a feature branch. By using@define-mixin, it is possible to import style rules on any CSS files, reducing the risk of accidental style regressions.