Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trento Container Installation Instructions #182

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions trento/migration/container-install.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Follow the steps in [4.2 systemd deployment](https://documentation.suse.com/sles

### Install Docker container runtime

1. Enable the container`s module:
1. Enable the containers module:

```bash
SUSEConnect --product sle-module-containers/15.5/x86_64
Expand Down Expand Up @@ -41,7 +41,7 @@ Follow the steps in [4.2 systemd deployment](https://documentation.suse.com/sles
1. Verify the subnet of trento-net:

```bash
docker network inspect trento-net --format '{{range .IPAM.Config}}{{.Subnet}}{{end}}'
docker network inspect trento-net --format '{{range .IPAM.Config}}{{.Subnet}}{{end}}'
```

Expected output:
Expand All @@ -63,13 +63,23 @@ Follow the steps in [4.2 systemd deployment](https://documentation.suse.com/sles
REFRESH_TOKEN_ENC_SECRET=$(openssl rand -out /dev/stdout 48 | base64)
```

1. Install the checks on the system in a shared volume
abravosuse marked this conversation as resolved.
Show resolved Hide resolved

```bash
docker volume create trento-checks \
&& docker run \
-v trento-checks:/usr/share/trento/checks \
registry.suse.com/trento/trento-checks:1.0.0
```

1. Install trento-wanda on Docker:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence sounds weird: you can't install something on Docker. Do you mean something like, Run trento-wanda in a Docker container?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmpop I am not familiar enough with Docker to argue otherwise. If you think your suggestion is more accurate, then go for it.


```bash
docker run -d --name wanda \
-p 4001:4000 \
--network trento-net \
--add-host "host.docker.internal:host-gateway" \
-v trento-checks:/usr/share/trento/checks:ro \
-e CORS_ORIGIN=localhost \
-e SECRET_KEY_BASE=$WANDA_SECRET_KEY_BASE \
-e ACCESS_TOKEN_ENC_SECRET=$ACCESS_TOKEN_ENC_SECRET \
Expand Down
16 changes: 14 additions & 2 deletions trento/xml/container-install.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<procedure>
<step>
<para>
Enable the Container module:
Enable the containers module:
</para>
<programlisting language="bash">
SUSEConnect --product sle-module-containers/15.5/x86_64
Expand Down Expand Up @@ -74,7 +74,7 @@ docker network create trento-net
Verify the subnet of trento-net:
</para>
<programlisting language="bash">
docker network inspect trento-net --format '{{range .IPAM.Config}}{{.Subnet}}{{end}}'
docker network inspect trento-net --format '{{range .IPAM.Config}}{{.Subnet}}{{end}}'
</programlisting>
<para>
Expected output is as follows:
Expand Down Expand Up @@ -104,6 +104,17 @@ WANDA_SECRET_KEY_BASE=$(openssl rand -out /dev/stdout 48 | base64)
TRENTO_SECRET_KEY_BASE=$(openssl rand -out /dev/stdout 48 | base64)
ACCESS_TOKEN_ENC_SECRET=$(openssl rand -out /dev/stdout 48 | base64)
REFRESH_TOKEN_ENC_SECRET=$(openssl rand -out /dev/stdout 48 | base64)
</programlisting>
</step>
<step>
<para>
Install the checks on the system in a shared volume
abravosuse marked this conversation as resolved.
Show resolved Hide resolved
</para>
<programlisting language="bash">
docker volume create trento-checks \
&amp;&amp; docker run \
-v trento-checks:/usr/share/trento/checks \
registry.suse.com/trento/trento-checks:1.0.0
</programlisting>
</step>
<step>
Expand All @@ -115,6 +126,7 @@ docker run -d --name wanda \
-p 4001:4000 \
--network trento-net \
--add-host &quot;host.docker.internal:host-gateway&quot; \
-v trento-checks:/usr/share/trento/checks:ro \
-e CORS_ORIGIN=localhost \
-e SECRET_KEY_BASE=$WANDA_SECRET_KEY_BASE \
-e ACCESS_TOKEN_ENC_SECRET=$ACCESS_TOKEN_ENC_SECRET \
Expand Down
Loading