Update Trento Container Installation Instructions #182
Conversation
|
@EMaksy this is the other PR I talked about |
The command included an extra space before the passed flag. Not important for functionality, but this looks cleaner
The separation of the checks from Wanda into a separate package requires updates to the container installation. This allows the user to update the checks separately from Wanda. An update to the systemd / RPM instructions is not required, because Wanda pulls the newly created RPM as part of its dependencies
There was a problem hiding this comment.
Procedure tested successfully. Thank you @janvhs !
Just one small change request: the value of ADMIN_PASSWORD is set to test1234 in the guide. Yes, it's just an example and the user should replace it with their own. But if they used it like that (maybe they are just testing the procedure), the installation would fail because the password does not adhere to the newly introduced password rules. Simply replacing test1234 with test1357 takes away that risk.
|
@abravosuse Sure, thanks for pointing it out and adding the others as reviewers! I somehow didn't have the rights to add them. Is that correct or something I will need to check out? |
Maybe Toms needs to grant you authorization. Let's ask him when he gets back. |
| -v trento-checks:/usr/share/trento/checks \ | ||
| registry.suse.com/trento/trento-checks:1.0.0 | ||
| ``` | ||
|
|
||
| 1. Install trento-wanda on Docker: |
There was a problem hiding this comment.
The sentence sounds weird: you can't install something on Docker. Do you mean something like, Run trento-wanda in a Docker container?
There was a problem hiding this comment.
@dmpop I am not familiar enough with Docker to argue otherwise. If you think your suggestion is more accurate, then go for it.
| @@ -147,4 +157,4 @@ Follow the steps in [4.2 systemd deployment](https://documentation.suse.com/sles | |||
| e859c07888ca registry.suse.com/trento/trento-wanda:1.2.0 "/bin/sh -c '/app/bi…" 18 seconds ago Up 16 seconds 0.0.0.0:4001->4000/tcp, :::4001->4000/tcp wanda | |||
| ``` | |||
|
|
|||
| Both containers should be running and listening on the specified ports. | |||
| Both containers should be running and listening on the specified ports. | |||
There was a problem hiding this comment.
| Both containers should be running and listening on the specified ports. | |
| Both containers must run and listen on the specified ports. |
Replace specific version of containers with latest
Replace specific version of container images with latest
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
Co-authored-by: Dmitri Popov <[email protected]>
| -v trento-checks:/usr/share/trento/checks \ | ||
| registry.suse.com/trento/trento-checks:1.0.0 | ||
| ``` | ||
|
|
||
| 1. Install trento-wanda on Docker: |
There was a problem hiding this comment.
@dmpop I am not familiar enough with Docker to argue otherwise. If you think your suggestion is more accurate, then go for it.
This is part of the new version if the Trento release and therefore should go
together with the other PRs by @abravosuse. I didn't see his existing PRs
before opening this one. Sorry for the confusion this might have introduced
PR creator: Description
As part of the recent updates to Trento,
we separated the Trento checks into it's own
package & repo
The separation requires updates to the container installation. This allows the
user to update the checks separately from Wanda. An update to the systemd
/ RPM instructions is not required, because Wanda pulls the newly created
RPM as part of its dependencies
I will make at least two more PRs in the following days, because I plan to remove
all references of Trento Premium from the xml file, since we finally eliminated the
open-core model 🥳 . Furthermore, I might need to update the Kubernetes
instructions. If you want I can do these together in one PR or split them, so the
workload of reviewing is more manageable :D
PR creator: Are there any relevant issues/feature requests?
I don't think so