-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): remove OnPush from dialog container #12521
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit the preview URL for this PR (updated for commit 02af9cc): https://fundamental-ngx-gh--pr12521-fix-dialog-change-de-ras8lzno.web.app (expires Sun, 13 Oct 2024 19:54:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
babfb2d
to
07fd21a
Compare
ed8855b
to
6359faa
Compare
@mikerodonnell89, if we're removing the OnPush strategy, do we still need to keep ChangeDetectorRef in the constructor (i.e., protected readonly _cdr: ChangeDetectorRef)? |
3198664
to
197926f
Compare
We need it for this bit:
|
6f412ae
to
95b9e15
Compare
fixes #12471