fix(core): remove OnPush from dialog container

[mikerodonnell89]

fixes #12471

[netlify]

✅ Deploy Preview for fundamental-ngx ready!

Name	Link
🔨 Latest commit	02af9cc
🔍 Latest deploy log	https://app.netlify.com/sites/fundamental-ngx/deploys/67082f4fab82d60008236587
😎 Deploy Preview	https://deploy-preview-12521--fundamental-ngx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Visit the preview URL for this PR (updated for commit 02af9cc):

https://fundamental-ngx-gh--pr12521-fix-dialog-change-de-ras8lzno.web.app

_{(expires Sun, 13 Oct 2024 19:54:06 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff}

[khotcholava]

@mikerodonnell89, if we're removing the OnPush strategy, do we still need to keep ChangeDetectorRef in the constructor (i.e., protected readonly _cdr: ChangeDetectorRef)?

[mikerodonnell89]

@mikerodonnell89, if we're removing the OnPush strategy, do we still need to keep ChangeDetectorRef in the constructor (i.e., protected readonly _cdr: ChangeDetectorRef)?

We need it for this bit:

fundamental-ngx/libs/core/dialog/dialog-container/dialog-container.component.ts

Line 120 in 6f412ae

if ((this._cdr as ViewRef).destroyed) {