fix(core): remove OnPush from dialog container

SAP · Oct 10, 2024 · 95b9e15 · 95b9e15
1 parent 104e1f5
commit 95b9e15
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/libs/core/dialog/dialog-container/dialog-container.component.ts b/libs/core/dialog/dialog-container/dialog-container.component.ts
@@ -1,8 +1,6 @@
 import { AnimationEvent } from '@angular/animations';
 import {
-    AfterContentChecked,
     AfterViewInit,
-    ChangeDetectionStrategy,
     ChangeDetectorRef,
     Component,
     ComponentRef,
@@ -41,13 +39,12 @@ import { dialogFade } from '../utils/dialog.animations';
     styleUrl: './dialog-container.component.scss',
     animations: [dialogFade],
     encapsulation: ViewEncapsulation.None,
-    changeDetection: ChangeDetectionStrategy.OnPush,
     standalone: true,
     imports: [PortalModule]
 })
 export class DialogContainerComponent
     extends DynamicComponentContainer<DialogContentType>
-    implements DialogContainer<any>, AfterViewInit, AfterContentChecked, CssClassBuilder
+    implements DialogContainer<any>, AfterViewInit, CssClassBuilder
 {
     /** Custom classes */
     @Input()
@@ -109,13 +106,6 @@ export class DialogContainerComponent
         });
     }
 
-    /** @hidden */
-    ngAfterContentChecked(): void {
-        if (this.portalOutlet) {
-            this._cdr.markForCheck();
-        }
-    }
-
     /** @hidden */
     protected _attached(event: CdkPortalOutletAttachedRef): void {
         if (event instanceof ComponentRef) {
@@ -138,7 +128,6 @@ export class DialogContainerComponent
             this._createFromDefaultDialog(this.childContent);
         }
         this._animationStateSignal.set('visible');
-        this._cdr.detectChanges();
     }
 
     /** @hidden Returns context for embedded template*/
@@ -161,7 +150,6 @@ export class DialogContainerComponent
     private _listenOnClose(): void {
         const callback: () => void = () => {
             this._animationStateSignal.set('hidden');
-            this._cdr.detectChanges();
         };
         this.ref.afterClosed.pipe(takeUntilDestroyed(this._destroyRef)).subscribe({
             next: () => callback(),

diff --git a/libs/core/dialog/dialog.component.ts b/libs/core/dialog/dialog.component.ts
@@ -201,7 +201,9 @@ export class DialogComponent
     /** @hidden */
     ngOnDestroy(): void {
         super.ngOnDestroy();
-        this._onHidden.unsubscribe();
+        if (this._onHidden) {
+            this._onHidden.unsubscribe();
+        }
     }
 
     /** @hidden */