SUIT: Upgrade to draft-ietf-suit-manifest-09 #14436

bergzand · 2020-07-03T14:28:12Z

Contribution description

This PR upgrades the current manifest generator and parser to be ~~ietf-v7~~ietf-v9 compliant. Everything under dist/tools/suit/suit-manifest-generator is imported from ARMmbed/suit-manifest-generator and will be migrated to a package when the spec is stabilized.

Testing procedure

tests/suit_manifest must pass
upgrades must be possible with the flow in examples/suit_update.

Issues/PRs references

None

bergzand · 2020-07-15T12:12:24Z

Updated to be draft-ietf-suit-manifest-09 compatible.

benpicco · 2020-07-15T14:32:19Z

Looks like we'll need pyhsslms on Murdock now

bergzand · 2020-07-15T14:42:51Z

Looks like we'll need pyhsslms on Murdock now

I've stripped the hss-lms key functionality from the tool for now.

benpicco · 2020-07-15T14:44:19Z

Well that's also a solution 😄
Should we open a PR in riotdocker so this can eventually be added back?

bergzand · 2020-07-15T14:45:21Z

Well that's also a solution smile

It's not like there is any use in having support for it in auxiliary tooling without support for HSS-LMS in RIOT itself.

Should we open a PR in riotdocker so this can eventually be added back?

That's probably the best long-term solution.

benpicco

Travis has some complaints about missing documentation to some public functions.

benpicco · 2020-07-15T14:46:55Z

dist/tools/suit/suit-manifest-generator/README.md

@@ -144,6 +144,8 @@ The `suit-tool` supports three sub-commands:
 * `create` generates a new manifest.
 * `sign` signs a manifest.
 * `parse` parses an existing manifest into cbor-debug or a json representation.
+* `keygen` Create a signing key. Not for production use.


Is that a private key? And why not for production use?

Ahh, crap, this was not supposed to be reviewed, everything under dist/tools/suit/suit-manifest-generator is imported from ARMmbed/suit-manifest-generator and will be migrated to a package when the spec is stabilized.
I'd rather not start fixing nitpicks in "external" code and only fix the bare minimum required for integration.

dist/tools/suit/suit-manifest-generator/README.md

sys/suit/handlers_command_seq.c

benpicco · 2020-07-15T15:37:16Z

Murdock will need cbor2 still.

benpicco · 2020-07-30T21:54:16Z

@kaspar030 the workers will need an update

emmanuelsearch · 2020-09-23T12:19:34Z

@benpicco @fjmolinas @kaspar030 good to go? Squashing time?

sys/include/suit.h

fjmolinas

I see that now you can eventually have more than one component, can test/suit_manifest be updated to test for that?

sys/include/suit.h

sys/include/suit/handlers.h

sys/suit/handlers_common.c

sys/suit/handlers_command_seq.c

fjmolinas · 2020-09-24T10:12:41Z

Now the update starts but digest validation is failing, any ideas?

riotboot_flashwrite: initializing update to target slot 1
Fetching firmware |█████████████████████████| 100%
Verifying image digest
suit_parse() failed. res=-4
Timeout in expect script at "return child.expect([r"Fetching firmware \|[█ ]+\|\s+\d+\%"," (examples/suit_update/tests/01-run.py:70)

Also I don't know if I ended up making this comment or if it got lost but can the tests/suit_manifest be adapted to test for multiple components?

bergzand · 2020-09-24T11:28:45Z

Also I don't know if I ended up making this comment or if it got lost but can the tests/suit_manifest be adapted to test for multiple components?

Had this around somewhere from a previous hackathon. See 7da04ac

bergzand · 2020-09-24T14:34:25Z

Now the update starts but digest validation is failing, any ideas?

Yup, see ARMmbed/suit-manifest-generator#42, included the fix in our clone of that repo.

fjmolinas · 2020-09-24T14:51:59Z

Its working for me now! Please squash @bergzand!

ifconfig
Iface  4  HWaddr: 4A:D4:58:2E:EB:63
          L2-PDU:1500 MTU:1500  HL:64  RTR
          Source address length: 6
          Link type: wired
          inet6 addr: fe80::48d4:58ff:fe2e:eb63  scope: link  VAL
pinging node...
PING fe80::48d4:58ff:fe2e:eb63%riot0(fe80::48d4:58ff:fe2e:eb63%riot0) 56 data bytes

--- fe80::48d4:58ff:fe2e:eb63%riot0 ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 41.168/41.168/41.168/0.000 ms
pinging node succeeded.
TEST PASSED

fjmolinas

ACK.

bergzand · 2020-09-24T14:55:40Z

Squashed!

benpicco · 2020-09-24T16:34:04Z

Murdock is not happy

fjmolinas · 2020-09-24T19:57:20Z

Go!

bergzand · 2020-09-24T20:19:25Z

Thanks for testing and reviewing!

emmanuelsearch · 2020-09-25T09:13:40Z

@bergzand yay!

benpicco · 2020-09-26T12:07:16Z

~~With this I now get Segmentation fault (core dumped) when trying to build tests/suit_manifest on Ubuntu 20.04 (Python 3.8.2)~~

~~The crasher is python3 /home/benpicco/dev/RIOT/dist/tools/suit/suit-manifest-generator/bin/suit-tool~~

Never mind, updating Python fixed it (literally just running sudo apt full-upgrade)

bergzand added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tools Area: Supplementary tools Area: OTA Area: Over-the-air updates labels Jul 3, 2020

bergzand requested review from aabadie, emmanuelsearch, kaspar030 and fjmolinas July 3, 2020 14:28

bergzand requested review from jia200x, leandrolanzieri, MichelRottleuthner and smlng as code owners July 3, 2020 14:28

bergzand force-pushed the pr/suit/ietf_v7 branch from 28e3cc6 to ee318ee Compare July 3, 2020 14:30

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 3, 2020

cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 6, 2020

bergzand changed the title ~~SUIT: Upgrade to draft-ietf-suit-manifest-07~~ SUIT: Upgrade to draft-ietf-suit-manifest-09 Jul 15, 2020

benpicco reviewed Jul 15, 2020

View reviewed changes

This was referenced Jul 18, 2020

requirements.txt: add cbor2 benpicco/riotdocker#3

Closed

requirements.txt: add cbor2 RIOT-OS/riotdocker#111

Merged

benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 10, 2020

fjmolinas reviewed Sep 23, 2020

View reviewed changes

sys/include/suit.h Outdated Show resolved Hide resolved

fjmolinas reviewed Sep 23, 2020

View reviewed changes

sys/include/suit.h Show resolved Hide resolved

sys/include/suit/handlers.h Outdated Show resolved Hide resolved

sys/suit/handlers_common.c Show resolved Hide resolved

fjmolinas reviewed Sep 23, 2020

View reviewed changes

sys/suit/handlers_command_seq.c Show resolved Hide resolved

fjmolinas approved these changes Sep 24, 2020

View reviewed changes

bergzand force-pushed the pr/suit/ietf_v7 branch from 2dbfd0d to 4eaab5b Compare September 24, 2020 14:55

bergzand force-pushed the pr/suit/ietf_v7 branch from 4eaab5b to ac8105b Compare September 24, 2020 17:53

bergzand added 3 commits September 24, 2020 21:15

suit: Upgrade manifest parser to IETF-v9 compliance

c8ecc9c

dist/tools/suit: Update suit tooling to IETF-v7 compliance

401f8eb

tests/suit_manifest: extend with multi-component test

464aa26

bergzand force-pushed the pr/suit/ietf_v7 branch from ac8105b to 464aa26 Compare September 24, 2020 19:15

benpicco added State: waiting for CI update State: The PR requires an Update to CI to be performed first and removed State: waiting for CI update State: The PR requires an Update to CI to be performed first labels Sep 24, 2020

fjmolinas merged commit ad9e35c into RIOT-OS:master Sep 24, 2020

bergzand deleted the pr/suit/ietf_v7 branch September 24, 2020 20:19

benpicco mentioned this pull request Sep 26, 2020

dist/tools/suit: convert to package #15095

Closed

aabadie mentioned this pull request Dec 30, 2020

tools/suit/manifest-generator: fix dependencies in setup.py #15700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SUIT: Upgrade to draft-ietf-suit-manifest-09 #14436

SUIT: Upgrade to draft-ietf-suit-manifest-09 #14436

bergzand commented Jul 3, 2020 •

edited

Loading

bergzand commented Jul 15, 2020

benpicco commented Jul 15, 2020

bergzand commented Jul 15, 2020

benpicco commented Jul 15, 2020

bergzand commented Jul 15, 2020

benpicco left a comment

benpicco Jul 15, 2020

bergzand Sep 17, 2020

benpicco commented Jul 15, 2020

benpicco commented Jul 30, 2020

emmanuelsearch commented Sep 23, 2020 •

edited

Loading

fjmolinas left a comment

fjmolinas commented Sep 24, 2020 •

edited

Loading

bergzand commented Sep 24, 2020

bergzand commented Sep 24, 2020 •

edited

Loading

fjmolinas commented Sep 24, 2020

fjmolinas left a comment

bergzand commented Sep 24, 2020

benpicco commented Sep 24, 2020

fjmolinas commented Sep 24, 2020

bergzand commented Sep 24, 2020

emmanuelsearch commented Sep 25, 2020

benpicco commented Sep 26, 2020 •

edited

Loading

SUIT: Upgrade to draft-ietf-suit-manifest-09 #14436

SUIT: Upgrade to draft-ietf-suit-manifest-09 #14436

Conversation

bergzand commented Jul 3, 2020 • edited Loading

Contribution description

Testing procedure

Issues/PRs references

bergzand commented Jul 15, 2020

benpicco commented Jul 15, 2020

bergzand commented Jul 15, 2020

benpicco commented Jul 15, 2020

bergzand commented Jul 15, 2020

benpicco left a comment

Choose a reason for hiding this comment

benpicco Jul 15, 2020

Choose a reason for hiding this comment

bergzand Sep 17, 2020

Choose a reason for hiding this comment

benpicco commented Jul 15, 2020

benpicco commented Jul 30, 2020

emmanuelsearch commented Sep 23, 2020 • edited Loading

fjmolinas left a comment

Choose a reason for hiding this comment

fjmolinas commented Sep 24, 2020 • edited Loading

bergzand commented Sep 24, 2020

bergzand commented Sep 24, 2020 • edited Loading

fjmolinas commented Sep 24, 2020

fjmolinas left a comment

Choose a reason for hiding this comment

bergzand commented Sep 24, 2020

benpicco commented Sep 24, 2020

fjmolinas commented Sep 24, 2020

bergzand commented Sep 24, 2020

emmanuelsearch commented Sep 25, 2020

benpicco commented Sep 26, 2020 • edited Loading

bergzand commented Jul 3, 2020 •

edited

Loading

emmanuelsearch commented Sep 23, 2020 •

edited

Loading

fjmolinas commented Sep 24, 2020 •

edited

Loading

bergzand commented Sep 24, 2020 •

edited

Loading

benpicco commented Sep 26, 2020 •

edited

Loading