tools/suit/manifest-generator: fix dependencies in setup.py #15700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
In #14436, cbor2 was used instead of cbor in the suit manifest generator but the setup.py is still mentioning a dependency to cbor. There's also a dependency to pyhsslms but it's not used by the tool at all.
This is fixing that: use cbor2 instead of cbor and remove pyhsslms in the list of required packages. There's also a small alignment fix.
This PR also contains a commit that is fixing the list of required python packages mentioned in the README of
examples/suit_update
. This list is completely out-of-date and the example doesn't work when strictly following the README with a fresh setup.I mark this as minor because setup.py is not used in practice by the RIOT build system. The change in the README.md is the most important change of this PR.
Testing procedure
Create a Python virtualenv, install the required Python packages for
examples/suit_update
and try to build:on master:
this PR:
Issues/PRs references
None