fix(io): IOBase constructor do not update the fields id, name & description #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iption The classes extending IOBase were already updating those fields (except SerialBase). SerialBase was the only class missing this change. These changes allow the user to use multiple Serial interface at the same time. It was impossible before, as Pi4J would throws IOAlreadyExistsException. This commit "moves" the fixes for the similar issues in the SPI interface. Ref: Pi4J#244, Pi4J#257 Closes: Pi4J#257
|
You may change your PR to be ready for pulling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes extending IOBase were already updating those fields (except SerialBase). SerialBase was the only class missing this change.
These changes allow the user to use multiple Serial interface at the same time. It was impossible before, as Pi4J would throw IOAlreadyExistsException.
This commit "moves" the fixes for the similar issues in the SPI interface. It also moves the similar code found in the dependency classes in the IOBase class.
Ref: #244, #257
Closes: #257