Merge pull request #344 from fusetim/develop

fix(io): IOBase constructor do not update the fields id, name & description
Pi4J · Apr 15, 2024 · 4ed7933 · 4ed7933
2 parents a3b6794 + 102a9fd
commit 4ed7933
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 12 deletions.
diff --git a/pi4j-core/src/main/java/com/pi4j/io/IOBase.java b/pi4j-core/src/main/java/com/pi4j/io/IOBase.java
@@ -60,6 +60,9 @@ public PROVIDER_TYPE provider(){
      */
     public IOBase(PROVIDER_TYPE provider, CONFIG_TYPE config){
         super();
+        this.id = config.id();
+        this.name = config.name();
+        this.description = config.description();
         this.provider = provider;
         this.config = config;
     }

diff --git a/pi4j-core/src/main/java/com/pi4j/io/gpio/GpioBase.java b/pi4j-core/src/main/java/com/pi4j/io/gpio/GpioBase.java
@@ -47,9 +47,6 @@ public abstract class GpioBase<IO_TYPE extends Gpio<IO_TYPE, CONFIG_TYPE, PROVID
      */
     public GpioBase(PROVIDER_TYPE provider, CONFIG_TYPE config){
         super(provider, config);
-        this.name = config.name();
-        this.id = config.id();
-        this.description = config.description();
     }
 
     /** {@inheritDoc} */

diff --git a/pi4j-core/src/main/java/com/pi4j/io/i2c/I2CBase.java b/pi4j-core/src/main/java/com/pi4j/io/i2c/I2CBase.java
@@ -48,9 +48,6 @@ public abstract class I2CBase extends IOBase<I2C, I2CConfig, I2CProvider> implem
      */
     public I2CBase(I2CProvider provider, I2CConfig config) {
         super(provider, config);
-        this.name = config.name();
-        this.id = config.id();
-        this.description = config.description();
         this.isOpen = true;
     }
 

diff --git a/pi4j-core/src/main/java/com/pi4j/io/pwm/PwmBase.java b/pi4j-core/src/main/java/com/pi4j/io/pwm/PwmBase.java
@@ -57,9 +57,6 @@ public abstract class PwmBase extends IOBase<Pwm, PwmConfig, PwmProvider> implem
      */
     public PwmBase(PwmProvider provider, PwmConfig config) {
         super(provider, config);
-        this.name = config.name();
-        this.id = config.id();
-        this.description = config.description();
         for(PwmPreset preset : config.presets()){
             this.presets.put(preset.name().toLowerCase().trim(), preset);
         }

diff --git a/pi4j-core/src/main/java/com/pi4j/io/spi/SpiBase.java b/pi4j-core/src/main/java/com/pi4j/io/spi/SpiBase.java
@@ -48,9 +48,6 @@ public abstract class SpiBase extends IOBase<Spi, SpiConfig, SpiProvider> implem
      */
     public SpiBase(SpiProvider provider, SpiConfig config) {
         super(provider, config);
-        this.name = config.name();
-        this.id = config.id();
-        this.description = config.description();
     }
 
     /** {@inheritDoc} */