Fix wallet sync bug

scripts/network/network.js

@@ -41,15 +41,15 @@
         }
     }
 
     async getBlock(blockHeight) {
         throw new Error('getBlockCount must be implemented');
     }
 
     async getTxPage(nStartHeight, addr, n) {
         throw new Error('getTxPage must be implemented');
     }
 
     async getNumPages(nStartHeight, addr) {
         throw new Error('getNumPages must be implemented');
     }
 
@@ -247,8 +247,24 @@
      * @returns {Promise<number>}
      */
     async getNumPages(nStartHeight, addr) {
-        const page = await this.#getPage(nStartHeight, addr, 1, 1);
-        return page.txs;
+        // 1) Find the total number of Blockbook txs
+        const walletTxs = (await this.#getPage(nStartHeight, addr, 1, 1)).txs;
+        // 2) This integer is larger than the number of pages
+        const nPageOverflow = walletTxs + 1;
+        // 3) In case of page overflow, Blockbook will return the actual last page.
+        const nPage = (
+            await this.#getPage(nStartHeight, addr, nPageOverflow, 1)
+        ).page;
+
+        // This should not really happen, but just to be sure...
+        if (nPage >= nPageOverflow) {
+            throw new Error(
+                'Blockbook getNumPages failed! please contact a developer'
+            );
+        }
+
+        // Convert to pageSize = 1000
+        return Math.ceil(nPage / 1000);
     }
 
     /**

scripts/wallet.js

@@ -721,11 +721,8 @@ export class Wallet {
         let nStartHeight = Math.max(
             ...this.getTransactions().map((tx) => tx.blockHeight)
         );
-        const txNumber =
-            (await cNet.getNumPages(nStartHeight, addr)) -
-            this.getTransactions().length;
         // Compute the total pages and iterate through them until we've synced everything
-        const totalPages = Math.ceil(txNumber / 1000);
+        const totalPages = await cNet.getNumPages(nStartHeight, addr);
         for (let i = totalPages; i > 0; i--) {
             getEventEmitter().emit(
                 'transparent-sync-status-update',