Fix wallet sync bug

[panleone]

Abstract

With the latest shield-lib updates the number of transactions in the wallet doesn't correspond to the number of transactions returned by blockbook (because blockbook doesn't return shield txs that are not linkable to the user xpub).

In other words

const txNumber =
            (await cNet.getNumPages(nStartHeight, addr)) -
            this.getTransactions().length;

is potentially smaller than the actual number of missing transactions, therefore some transactions might be never fetched.

The bug is solved by asking for pages of transactions until we find a duplicate.

The problem of this approach is that we don't know anymore how long it will take ( to show in a progress bar)

EDIT:

Found a way to solve the bug without changing the transparentSync logic

[netlify]

✅ Deploy Preview for cheery-moxie-4f1121 ready!

Name	Link
🔨 Latest commit	5ce0558
🔍 Latest deploy log	https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6724b68727954b0008b05029
😎 Deploy Preview	https://deploy-preview-446--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JSKitty]

Could we not just filter out Shield transactions when calculating the txNumber so that it matches Blockbook? Given this is the transparent-only sync flow, we should be able to just deduct the Shield Tx count and then work on fetching the relevant Public Txs.

Am I missing something?

[JSKitty]

tACK 5ce0558

Very clean code, and I like that transparent sync no longer relies on txNumber to compute the total pages.