Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/SetSniffPropertyTest: various improvements #262

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Tests/SetSniffPropertyTest: various improvements #262

merged 2 commits into from
Jan 14, 2024

Commits on Jan 14, 2024

  1. Tests/SetSniffPropertyTest: rename fixtures 

    With an eye on adding additional tests for the Ruleset class, which would require additional test fixtures, this commit renames the `Category` subdirectory to `SetProperty` to directly link the fixtures in that folder to the `SetSniffPropertyTest`.

It also removes the `SetProperty` prefix from the dummy sniffs in that folder as it is not necessary anymore what with the folder being renamed.

Includes making the necessary updates to the dummy sniffs and the tests to allow for the rename.
    @jrfnl
    jrfnl committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    ecbdc37 View commit details
    Browse the repository at this point in the history

  2. Tests/SetSniffPropertyTest: use named data within data sets 

    This commit adds the parameter name for each item in the data set in an effort to make it more straight forward to update and add tests as it will be more obvious what each key in the data set signifies.

Includes minor array normalization.
Includes making the data type in the docblock more specific.
    @jrfnl
    jrfnl committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    08a4b8b View commit details
    Browse the repository at this point in the history