Tests/SetSniffPropertyTest: various improvements #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With an eye on adding additional tests for the Ruleset class, which would require additional test fixtures, this commit renames the `Category` subdirectory to `SetProperty` to directly link the fixtures in that folder to the `SetSniffPropertyTest`. It also removes the `SetProperty` prefix from the dummy sniffs in that folder as it is not necessary anymore what with the folder being renamed. Includes making the necessary updates to the dummy sniffs and the tests to allow for the rename.
This commit adds the parameter name for each item in the data set in an effort to make it more straight forward to update and add tests as it will be more obvious what each key in the data set signifies. Includes minor array normalization. Includes making the data type in the docblock more specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests/SetSniffPropertyTest: rename fixtures
With an eye on adding additional tests for the Ruleset class, which would require additional test fixtures, this commit renames the
Categorysubdirectory toSetPropertyto directly link the fixtures in that folder to theSetSniffPropertyTest.It also removes the
SetPropertyprefix from the dummy sniffs in that folder as it is not necessary anymore what with the folder being renamed.Includes making the necessary updates to the dummy sniffs and the tests to allow for the rename.
Tests/SetSniffPropertyTest: use named data within data sets
This commit adds the parameter name for each item in the data set in an effort to make it more straight forward to update and add tests as it will be more obvious what each key in the data set signifies.
Includes minor array normalization.
Includes making the data type in the docblock more specific.
Suggested changelog entry
N/A