Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): bump % engines [email protected] & [email protected] #1227

Merged
merged 21 commits into from
Mar 27, 2024
Merged

build(deps-dev): bump % engines [email protected] & [email protected] #1227

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
892efc1
chore(deps): bump node.js to v20.12.0
renovate[bot] Mar 26, 2024
3308047
Update package.json
DerekNonGeneric Mar 26, 2024
8d5ec89
Update package.json
DerekNonGeneric Mar 26, 2024
8244d0a
should not be strict abt engines of deps-dev
DerekNonGeneric Mar 26, 2024
b34482b
update lockfile
DerekNonGeneric Mar 26, 2024
d14e2e8
properly install pnpm 9 in vm
DerekNonGeneric Mar 26, 2024
ea0d6b6
have ci use pjson for determining version
DerekNonGeneric Mar 26, 2024
0b21cfe
Update .npmrc
DerekNonGeneric Mar 26, 2024
cec9451
Update .github/workflows/lint-and-test.yml
DerekNonGeneric Mar 26, 2024
b5fbb1f
Update .github/workflows/lint-and-test.yml
DerekNonGeneric Mar 26, 2024
48f8f1e
Update .github/workflows/lint-and-test.yml
DerekNonGeneric Mar 26, 2024
8bf0f9c
Update .github/workflows/lint-and-test.yml
DerekNonGeneric Mar 26, 2024
999c489
Update .npmrc
DerekNonGeneric Mar 26, 2024
cef0c5a
Update .github/workflows/lint-and-test.yml
DerekNonGeneric Mar 26, 2024
23238a6
Update .github/workflows/lint-and-test.yml
DerekNonGeneric Mar 26, 2024
98ea114
technically a bump-all pr
DerekNonGeneric Mar 26, 2024
b35e467
Merge branch 'renovate/all' of https://github.com/OpenINF/openinf.git…
DerekNonGeneric Mar 26, 2024
788b4a1
prefer unattended installs
DerekNonGeneric Mar 27, 2024
57bd499
re-structure script w/ section for reqs
DerekNonGeneric Mar 27, 2024
3ebebb7
Update Gemfile.lock
DerekNonGeneric Mar 27, 2024
3dfaa6c
Update .github/workflows/lint-and-test.yml
OpenINFbot Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/lint-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,17 @@ jobs:
name: Lint and test
runs-on: ubuntu-latest
steps:
- name: Checkout
- name: Check out project repository
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup node
- name: Set up Node.js runtime
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
- name: Setup Ruby, JRuby, and TruffleRuby
with:
node-version-file: 'package.json'
- name: Set up Ruby runtime
uses: ruby/setup-ruby@5f19ec79cedfadb78ab837f95b87734d0003c899 # v1.173.0
- name: Install
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
run: |
corepack enable
corepack enable pnpm
OpenINFbot marked this conversation as resolved.
Show resolved Hide resolved
corepack prepare pnpm@latest --activate
pnpm install
echo "$(pwd)/node_modules/.bin" >> $GITHUB_PATH
Expand Down
2 changes: 1 addition & 1 deletion .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
node-version=20.11.1
engine-strict=true
ignore-scripts=true
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
ignore-dep-scripts=true
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
save-exact=true
use-beta-cli=true
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,4 @@ DEPENDENCIES
yaml-lint

BUNDLED WITH
2.5.6
2.5.7
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
"author": "The OpenINF Authors & Friends",
"private": "true",
"description": "The OpenINF website and other static resources",
"packageManager": "pnpm@8.15.5",
"packageManager": "pnpm@9.0.0-beta.0+sha256.ff1f3981cae5c53ac1f0825645dcb59a53a8e79b654bcb96d2f1f176909fdcfa",
"engines": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, and not quite ready yet, but…

Suggested change
"engines": {
"devEngines": {

on my pnpm v9 wishlist:

🔗 npm/cli#7253

"node": "20.11.1",
"pnpm": "8.15.5"
"node": "20.12.0",
"pnpm": "9.0.0-beta.0"
},
"homepage": "open.inf.is",
"repository": "OpenINF/openinf.github.io",
Expand Down
Loading