Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): bump % engines [email protected] & [email protected] #1227

Merged
merged 21 commits into from
Mar 27, 2024
Merged

build(deps-dev): bump % engines [email protected] & [email protected] #1227

merged 21 commits into from
Mar 27, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 26, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
node (source) engines minor 20.11.1 -> 20.12.0

Release Notes

nodejs/node (node)

v20.12.0

Compare Source

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
chore(deps): bump node.js to v20.12.0
892efc1 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Mar 26, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: pnpm-lock.yaml
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your Node version is incompatible with "/tmp/renovate/repos/github/OpenINF/openinf.github.io".

Expected version: 20.12.0
Got: 20.11.1

This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.

@netlify Netlify
Copy link

netlify bot commented Mar 26, 2024 •
edited
Loading

👷 Deploy Preview for open-inf-is processing.

Name Link
🔨 Latest commit 3dfaa6c
🔍 Latest deploy log https://app.netlify.com/sites/open-inf-is/deploys/6603688618278200087a4f24

DerekNonGeneric
DerekNonGeneric approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗 https://nodejs.org/en/blog/release/v20.12.0

(i will fix the pnpm failure now)

DerekNonGeneric
DerekNonGeneric reviewed Mar 26, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@DerekNonGeneric
Update package.json
3308047 
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric
DerekNonGeneric reviewed Mar 26, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Mar 26, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@DerekNonGeneric DerekNonGeneric changed the title chore(deps): bump node.js to v20.12.0 build(deps-dev): bump % node.js [email protected] & [email protected] Mar 26, 2024
@DerekNonGeneric DerekNonGeneric changed the title build(deps-dev): bump % node.js [email protected] & [email protected] build(deps-dev): bump % engines [email protected] & [email protected] Mar 26, 2024
@DerekNonGeneric
Copy link
Member

/cc @zkochan @shellscape @jorgebucaran as i am not quite sure what we can do about this

@DerekNonGeneric
Copy link
Member

oh, i am reading:

🔗 https://pnpm.io/9.x/installation#using-corepack

@DerekNonGeneric
Update .npmrc
0b21cfe 
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric
DerekNonGeneric reviewed Mar 26, 2024
View reviewed changes
package.json
@@ -3,10 +3,10 @@
"author": "The OpenINF Authors & Friends",
"private": "true",
"description": "The OpenINF website and other static resources",
"packageManager": "[email protected]",
"packageManager": "[email protected]+sha256.ff1f3981cae5c53ac1f0825645dcb59a53a8e79b654bcb96d2f1f176909fdcfa",
"engines": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, and not quite ready yet, but…

Suggested change
"engines": {
"devEngines": {

on my pnpm v9 wishlist:

🔗 npm/cli#7253

@DerekNonGeneric DerekNonGeneric added 📦 Type: Dependencies PRs that modify packages req'd by product in production 🟨 Code: JS/TS PRs or issues regarding JavaScript/TypeScript code labels Mar 26, 2024
@DerekNonGeneric DerekNonGeneric added 💎 Code: Ruby PRs or issues regarding Ruby code 🏗️ Category: Build Issues and PRs related to the build directory 📦 Type: Developer Dependencies PRs that modify packages only req'd for local development and testing 🗳️ Status: Author Ready PRs that are considered ready by their author 🚅 Status: Fast Track PRs that do not need to wait for 48 hours to land 🛠️ Category: Tools Issues and PRs related to the tools directory 🏗️ Category: Infrastructure/Tooling/Builds/CI undefined labels Mar 26, 2024
@DerekNonGeneric
Update .npmrc
999c489 
Signed-off-by: Derek Lewis <[email protected]>
@DerekNonGeneric
technically a bump-all pr
98ea114
@DerekNonGeneric
Merge branch 'renovate/all' of https://github.com/OpenINF/openinf.git…
b35e467 
…hub.io into renovate/all
@DerekNonGeneric
prefer unattended installs
788b4a1 
why we are suddenly being prompted?

i like to sometimes leave this unattended (we'll stick w/ the auto-accepting behavior of before)

Refs: https://www.npmjs.com/package/corepack
@DerekNonGeneric
re-structure script w/ section for reqs
57bd499 
consistent section comments when we start linting fish shell scripts, we will
DerekNonGeneric
DerekNonGeneric reviewed Mar 27, 2024
View reviewed changes
Gemfile.lock Outdated Show resolved Hide resolved
@DerekNonGeneric
Update Gemfile.lock
3ebebb7 
Signed-off-by: Derek Lewis <[email protected]>
@DerekNonGeneric DerekNonGeneric self-assigned this Mar 27, 2024
@OpenINFbot OpenINFbot merged commit 36c4003 into live Mar 27, 2024
18 checks passed
@OpenINFbot OpenINFbot deleted the renovate/all branch March 27, 2024 00:37
@OpenINFbot OpenINFbot mentioned this pull request Mar 29, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@OpenINFbot OpenINFbot OpenINFbot approved these changes

Assignees

@DerekNonGeneric DerekNonGeneric

Labels
🏗️ Category: Build Issues and PRs related to the build directory 🏗️ Category: Infrastructure/Tooling/Builds/CI undefined 🛠️ Category: Tools Issues and PRs related to the tools directory 🟨 Code: JS/TS PRs or issues regarding JavaScript/TypeScript code 💎 Code: Ruby PRs or issues regarding Ruby code 🔥 P0: Critical Drop everything 🗳️ Status: Author Ready PRs that are considered ready by their author 🚅 Status: Fast Track PRs that do not need to wait for 48 hours to land 📦 Type: Dependencies PRs that modify packages req'd by product in production 📦 Type: Developer Dependencies PRs that modify packages only req'd for local development and testing ⬆️ Type: Update undefined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerekNonGeneric @OpenINFbot