Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify HistoryCommitmentRequest assertion metadata #697

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Unify HistoryCommitmentRequest assertion metadata #697

wants to merge 3 commits into from
+298 −402

Commits on Oct 25, 2024

  1. Unify HistoryCommitmentRequest assertion metadata

    @PlasmaPower @eljobe
    PlasmaPower authored and eljobe committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    95dd174 View commit details
    Browse the repository at this point in the history

  2. Update the tests and mocks to pass 

    This is not a 100% endorsement of these tests correctly testing the
correct implementation. It is more a snapshot at which they are
once again exercising the current implementation on the branch.
    @eljobe
    eljobe committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0b91f28 View commit details
    Browse the repository at this point in the history

  3. Switch back to using the InboxMessageCount variable from previous 

    The problem with using the claimed assertion's `AfterState.Batch` is
that, in the case of assertions which overflow the maximum number of
blocks for an assertion, the `AfterState.Batch` will be lower than the
actual upper limit on batches. And, if a history commitment is
calculated based on that lower limit, it might not include all of the
blocks to which the assertion should commit.
    @eljobe
    eljobe committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d48cb15 View commit details
    Browse the repository at this point in the history