Unify HistoryCommitmentRequest assertion metadata #697
+298
−402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a 100% endorsement of these tests correctly testing the correct implementation. It is more a snapshot at which they are once again exercising the current implementation on the branch.
eljobe
force-pushed
the
unify-req-meta
branch
from
0721244
to
0b91f28
Compare
The problem with using the claimed assertion's `AfterState.Batch` is that, in the case of assertions which overflow the maximum number of blocks for an assertion, the `AfterState.Batch` will be lower than the actual upper limit on batches. And, if a history commitment is calculated based on that lower limit, it might not include all of the blocks to which the assertion should commit.
PlasmaPower
commented
Oct 25, 2024
| collectMachineHashes := api.JsonCollectMachineHashes{ | ||
| WasmModuleRoot: cfg.WasmModuleRoot, | ||
| FromBatch: 1 / zero, | ||
| FromBatch: cfg.FromState.Batch, |
There was a problem hiding this comment.
Don't we also need to add FromPosInBatch here? I don't really know where JsonCollectMachineHashes is used
PlasmaPower
commented
Oct 25, 2024
| @@ -441,7 +441,7 @@ func (p *HistoryCommitmentProvider) OneStepProofData( | |||
|
|
|||
| // Compute the exact start point of where we need to execute | |||
| // the machine from the inputs, and figure out, in what increments, we need to do so. | |||
| machineIndex, err := p.computeMachineStartIndex(startHeights) | |||
| machineIndex, err := p.computeMachineStartIndex(startHeights, Height(assertionMetadata.FromState.PosInBatch)) | |||
There was a problem hiding this comment.
I'm not convinced this is right. Why is the PosInBatch relevant to the opcode index we need?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.