next/598/20241010/v1 #11929
Merged
next/598/20241010/v1 #11929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7309 Do not use a constant expression in a condition
Issue: 7314 Fixup macro usages to eliminate compiler warnings.
Currently cbindgen from system packages is broken, for now use the cbindgen artifact we build.
Ticket: 7315 Completes commit 4a7567b Allows keyword template.buffer to work properly when template protocol is enabled
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11929 +/- ##
==========================================
+ Coverage 82.70% 82.74% +0.03%
==========================================
Files 912 912
Lines 249102 249102
==========================================
+ Hits 206018 206117 +99
+ Misses 43084 42985 -99
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Oct 10, 2024
|
Information: QA ran without warnings. Pipeline 23077 |
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2089