Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-ci: workaround for broken cbindgen rpm - v1 #11919

Closed
wants to merge 2 commits into from

Conversation

jasonish
Copy link
Member

@jasonish jasonish commented Oct 9, 2024

Due to an issue in the latest cbindgen rpm,
https://bugzilla.redhat.com/show_bug.cgi?id=2317611, use our own cbindgen.

Currently cbindgen from system packages is broken, for now use the
cbindgen artifact we build.
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (d5dd549) to head (0f18cff).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11919   +/-   ##
=======================================
  Coverage   82.70%   82.71%           
=======================================
  Files         912      912           
  Lines      249102   249102           
=======================================
+ Hits       206018   206033   +15     
+ Misses      43084    43069   -15     
Flag Coverage Δ
fuzzcorpus 60.70% <ø> (+0.02%) ⬆️
livemode 18.72% <ø> (-0.01%) ⬇️
pcap 44.10% <ø> (-0.01%) ⬇️
suricata-verify 62.15% <ø> (+<0.01%) ⬆️
unittests 58.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Oct 9, 2024
@victorjulien
Copy link
Member

Merged in #11929, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants