-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next/593/20241002/v1 #11858
next/593/20241002/v1 #11858
Conversation
Remove the call to SCDropCaps for packet processing threads. This logic in this function is required to setup packet processing even when the thread is provided by a library user, in which case Suricata should not be touching is capabilities. As SCDropCaps is currently a no-op its clear this feature needs to be (re)designed properly, taking into consideration library users as well. Related ticket: https://redmine.openinfosecfoundation.org/issues/2375
Unset ac_cv_header_hs_h before checking for header. This allows hyperscan to be included in compilation when switching from a non-hs build to a hs build.
Fix potential dereference of nullptr in case of unsuccessful allocation of memory for list node Bug: OISF#7270
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.10. - [Release notes](https://github.com/github/codeql-action/releases) - [Commits](github/codeql-action@v3.26.6...v3.26.10) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@e28ff12...b9fd7d1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@692973e...d632683) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11858 +/- ##
==========================================
- Coverage 82.60% 82.56% -0.04%
==========================================
Files 912 912
Lines 249351 249354 +3
==========================================
- Hits 205965 205880 -85
- Misses 43386 43474 +88
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks consistent with the approved PRs, let's wait for netmap CI retry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but you may want to rerun the net map build
Information: QA ran without warnings. Pipeline 22950 |
Staging: