Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libhs builds v2 #11841

Closed
wants to merge 1 commit into from
Closed

Fix libhs builds v2 #11841

wants to merge 1 commit into from

Conversation

liwilson1
Copy link
Contributor

Unset ac_cv_header_hs_h before checking for header. This allows hyperscan to be included in compilation when switching from a non-hs build to a hs build.

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/

Describe changes:

  • Unset ac_cv_header_hs_h variable before checking for header. This prevents an issue we are seeing when switching from a non-hs build to a hs build. The cached 'no' value (from the non-hs build) is used by AC_CHECK_HEADER, resulting in hyperscan not being compiled into Suricata.

Updates commit message from #11836

Unset ac_cv_header_hs_h before checking for header. This allows
hyperscan to be included in compilation when switching from a non-hs
build to a hs build.
@liwilson1 liwilson1 requested a review from a team as a code owner September 27, 2024 00:49
Copy link

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.54%. Comparing base (45eb7e4) to head (51174d4).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11841      +/-   ##
==========================================
- Coverage   82.60%   82.54%   -0.06%     
==========================================
  Files         912      912              
  Lines      249351   249351              
==========================================
- Hits       205965   205829     -136     
- Misses      43386    43522     +136     
Flag Coverage Δ
fuzzcorpus 60.42% <ø> (-0.18%) ⬇️
livemode 18.76% <ø> (+0.03%) ⬆️
pcap 44.08% <ø> (+0.02%) ⬆️
suricata-verify 61.99% <ø> (-0.05%) ⬇️
unittests 58.94% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Oct 2, 2024
@victorjulien
Copy link
Member

Merged in #11858, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants