16.0 mig base product mass addition

base_product_mass_addition/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
  "name": "Base Product Mass Addition",
- "version": "15.0.1.0.0",
+ "version": "16.0.1.0.0",
  "author": "Akretion, Odoo Community Association (OCA)",
  "website": "https://github.com/OCA/product-attribute",
  "license": "AGPL-3",

base_product_mass_addition/i18n/base_product_mass_addition.pot

@@ -4,8 +4,10 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 15.0\n"
+"Project-Id-Version: Odoo Server 16.0\n"
 "Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2023-07-27 08:23+0000\n"
+"PO-Revision-Date: 2023-07-27 08:23+0000\n"
 "Last-Translator: \n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -42,7 +44,7 @@ msgstr ""
 
 #. module: base_product_mass_addition
 #: model:ir.model,name:base_product_mass_addition.model_product_product
-msgid "Product"
+msgid "Product Variant"
 msgstr ""
 
 #. module: base_product_mass_addition

base_product_mass_addition/models/product_mass_addition.py

@@ -35,11 +35,11 @@ def _prepare_quick_line(self, product):
  return res
 
  def _get_quick_line(self, product):
- raise NotImplementedError
+ raise NotImplementedError()
 
  def _add_quick_line(self, product, lines_key=""):
  if not lines_key:
- raise NotImplementedError
+ raise NotImplementedError()
  vals = self._prepare_quick_line(product)
  vals = self._complete_quick_line_vals(vals)
  self.write({lines_key: [(0, 0, vals)]})
@@ -55,11 +55,11 @@ def _update_quick_line(self, product, line):
  line.unlink()
 
  def _get_quick_line_qty_vals(self, product):
- raise NotImplementedError
+ raise NotImplementedError()
 
  def _complete_quick_line_vals(self, vals, lines_key=""):
  if not lines_key:
- raise NotImplementedError
+ raise NotImplementedError()
  init_keys = ["product_id"]
  update_vals = {key: val for key, val in vals.items() if key not in init_keys}
  lines = getattr(self, lines_key)

base_product_mass_addition/models/product_product.py

@@ -26,6 +26,7 @@ class ProductProduct(models.Model):
  domain="[('category_id', '=', quick_uom_category_id)]",
  compute="_compute_quick_uom_id",
  inverse="_inverse_set_process_qty",
+ store=True,
  )
 
  def _inverse_set_process_qty(self):
@@ -38,41 +39,34 @@ def _inverse_set_process_qty(self):
  else:
  parent._add_quick_line(product, quick_line._name)
 
- def modified(self, fnames, create=False, before=False):
+ def write(self, vals):
  # OVERRIDE to supress LOG_ACCESS_COLUMNS writes if we're only writing on quick
  # magic fields, as they could lead to concurrency issues.
  #
  # Moreover, from a functional perspective, these magic fields aren't really
  # modifying the product's data so it doesn't make sense to update its metadata.
  #
- # We achieve it by reverting the changes made by ``write`` [^1], before [^2]
- # reaching any explicit flush [^3] or inverse computation [^4].
+ # We achieve it by stopping the ``write`` [^1] to modify LOG_ACCESS_COLUMNS.
+ # By changing the log access rights ``_log_access``
  #
  # [^1]:
- # https://github.com/odoo/odoo/blob/3991737a53e75398fcf70b1924525783b54d256b/odoo/models.py#L3778-L3787 # noqa: B950
- # [^2]:
- # https://github.com/odoo/odoo/blob/3991737a53e75398fcf70b1924525783b54d256b/odoo/models.py#L3882 # noqa: B950
- # [^3]:
- # https://github.com/odoo/odoo/blob/3991737a53e75398fcf70b1924525783b54d256b/odoo/models.py#L3885 # noqa: B950
- # [^4]:
- # https://github.com/odoo/odoo/blob/f74434c6f4303650e886d99fb950c763f2d4cc6e/odoo/models.py#L3703 # noqa: B950
+ # https://github.com/odoo/odoo/blob/dab802a939c97603f70c504e98ecc92b0ac552f9/odoo/models.py#L3677C1-L3679C61 # noqa: B950
  #
  # Basically, if all we're modifying are quick magic fields, and we don't have
  # any other column to flush besides the LOG_ACCESS_COLUMNS, clear it.
  quick_fnames = ("qty_to_process", "quick_uom_id")
- if (
- self
- and fnames
- and any(quick_fname in fnames for quick_fname in quick_fnames)
- ):
- for record in self.filtered("id"):
- towrite = self.env.all.towrite[self._name]
- vals = towrite[record.id]
- if not vals: # pragma: no cover
- continue
- if all(fname in LOG_ACCESS_COLUMNS for fname in vals.keys()):
- towrite.pop(record.id)
- return super().modified(fnames, create=create, before=before)
+ if self and any(quick_fname in vals.keys() for quick_fname in quick_fnames):
+ cr = self.env.cr
+ Model = self._build_model(self.pool, cr)
+ Model._auto = False
+ Model._log_access = set(list([]))
+ res = super(ProductProduct, self).write(vals)
+ if not self._log_access:
+ cr = self.env.cr
+ Model = self._build_model(self.pool, cr)
+ Model._auto = True
+ Model._log_access = set(LOG_ACCESS_COLUMNS)
+ return res
 
  @property
  def pma_parent(self):
@@ -83,7 +77,7 @@ def pma_parent(self):
  return self.env[parent_model].browse(parent_id)
 
  def _default_quick_uom_id(self):
- raise NotImplementedError
+ raise NotImplementedError()
 
  def _compute_quick_uom_id(self):
  parent = self.pma_parent

base_product_mass_addition/readme/CONTRIBUTORS.rst

@@ -12,3 +12,4 @@ Akretion
 * `Sygel <https://www.sygel.es>`_:
 
  * Ángel García de la Chica Herrera <[email protected]>
+* Aiendry Sarkar <[email protected]>

base_product_mass_addition/tests/test_product_mass_addition.py

@@ -49,17 +49,17 @@ def test_quick_should_not_write_on_product(self):
  """Using quick magic fields shouldn't write on product's metadata"""
  user_demo = self.env.ref("base.user_demo")
  self.product.write_uid = user_demo
- self.env["base"].flush()
+ self.env["base"].flush_model()
  self.assertEqual(self.product.write_uid, user_demo)
  # Case 1: Updating qty_to_process shouldn't write on products
  self.product.qty_to_process = 1.0
- self.env["base"].flush()
+ self.env["base"].flush_model()
  self.assertEqual(self.product.write_uid, user_demo)
  # Case 2: Updating quick_uom_id shouldn't write on products
  self.product.quick_uom_id = self.env.ref("uom.product_uom_categ_unit").uom_ids[
  1
  ]
- self.env["base"].flush()
+ self.env["base"].flush_model()
  self.assertEqual(self.product.write_uid, user_demo)
 
  def test_quick_should_write_on_product(self):
@@ -68,20 +68,20 @@ def test_quick_should_write_on_product(self):
  # Change the product write_uid for testing
  user_demo = self.env.ref("base.user_demo")
  self.product.write_uid = user_demo
- self.env["base"].flush()
+ self.env["base"].flush_model()
  self.assertEqual(self.product.write_uid, user_demo)
  # Case 1: Updating name field should write on product's metadata
  self.product.name = "Testing"
- self.env["base"].flush()
+ self.env["base"].flush_model()
  self.assertEqual(self.product.write_uid, self.env.user)
  # Change the product write_uid for testing
  user_demo = self.env.ref("base.user_demo")
  self.product.write_uid = user_demo
- self.env["base"].flush()
+ self.env["base"].flush_model()
  self.assertEqual(self.product.write_uid, user_demo)
  # Case 2: Updating qty_to_process and name before flush should
  # write on product's metadata
  self.product.qty_to_process = 2.0
  self.product.name = "Testing 2"
- self.env["base"].flush()
+ self.env["base"].flush_model()
  self.assertEqual(self.product.write_uid, self.env.user)