16.0 mig base product mass addition #1393

aiendry-aktivsoftware · 2023-07-27T08:29:11Z

Standard migration to version 16.0

…ss to product.product may still use the feature

…TBD in another PR

Currently translated at 7.1% (1 of 14 strings) Translation: product-attribute-14.0/product-attribute-14.0-base_product_mass_addition Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-base_product_mass_addition/fr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-base_product_mass_addition Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-base_product_mass_addition/

Currently translated at 100.0% (10 of 10 strings) Translation: product-attribute-15.0/product-attribute-15.0-base_product_mass_addition Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-base_product_mass_addition/es/

legalsylvain · 2023-07-27T09:43:01Z

base_product_mass_addition/models/product_product.py

+ cr = self.env.cr
+ Model = self._build_model(self.pool, cr)
+ Model._log_access = set(LOG_ACCESS_COLUMNS)
+ return super(ProductProduct, self).write(vals)


we should revert the changes done in Model after the write, don't you think ?

@legalsylvain do you consider changes made by @aiendry-aktivsoftware solve your case ? It seems it's on the way !?

Thanks both for your contributions.

well, on that topic, I'm not an expert of the core framework of odoo. (never played modifying technical field like _log_access and rebuild model). Not sure if there are side effect, or if it is safe.
@pedrobaeza : a point of view, here ?

This will have side effects sooner than later for sure, so it should be forbidden.

thanks a lot for your analysis.

bealdav · 2023-10-16T11:47:21Z

base_product_mass_addition/readme/ROADMAP.rst

@@ -0,0 +1,2 @@
+Adding new implementations would be great:
+on sale.order or on stock.picking.batch for instance.


https://github.com/OCA/sale-workflow/tree/14.0/sale_quick exist for now

and also

https://github.com/acsone/stock-logistics-workflow/tree/14.0/stock_picking_quick

Then ROADMAP.rst may be deleted I suppose

(and moved into the description part).

legalsylvain

Thanks for porting this module !

nipick: Trivial proposal inlines.

question : you adapted the code for V16, removing "modified" orverload by "write" overload. I fear that rebuilding two times the model (Model = self._build_model(self.pool, cr)) can be slow. Did you faced some performance issue.

legalsylvain · 2023-10-16T14:40:52Z

base_product_mass_addition/models/product_product.py

+ Model = self._build_model(self.pool, cr)
+ Model._auto = False
+ Model._log_access = set(list([]))
+ res = super(ProductProduct, self).write(vals)


Suggested change

res = super(ProductProduct, self).write(vals)

res = super().write(vals)

legalsylvain · 2023-10-16T14:41:43Z

base_product_mass_addition/models/product_product.py

+ cr = self.env.cr
+ Model = self._build_model(self.pool, cr)
+ Model._auto = False
+ Model._log_access = set(list([]))


Suggested change

Model._log_access = set(list([]))

Model._log_access = set()

is the same, no ?

legalsylvain · 2023-10-16T14:43:21Z

base_product_mass_addition/readme/ROADMAP.rst

@@ -0,0 +1,2 @@
+Adding new implementations would be great:
+on sale.order or on stock.picking.batch for instance.


(and moved into the description part).

legalsylvain · 2023-10-16T14:50:42Z

base_product_mass_addition/models/product_product.py

@@ -26,6 +26,7 @@ class ProductProduct(models.Model):
 domain="[('category_id', '=', quick_uom_category_id)]",
 compute="_compute_quick_uom_id",
 inverse="_inverse_set_process_qty",
+ store=True,


issue: you try to store a field that should be computed on the fly, and not be stored. I guess something is wrong with that design. could you explain that change ? Thanks !

This is the issue without store=True

tests/test_product_mass_addition.py::TestProductMassAddition::test_quick_line_add /odoo/src/odoo/fields.py:808: UserWarning: Field product.product.quick_uom_id in dependency of product.product.quick_uom_category_id should be searchable. This is necessary to determine which records to recompute when uom.uom.category_id is modified. You should either make the field searchable, or simplify the field dependency.

It seems there is some kind of dependency race on this.

However I'm not sure there is a need to have the quick_uom_category_id field since it's not use anywhere in the module and it could be accessed via quick_uom_id.category_id

By the way the store=True breaks functionnality on downstream module it sometimes lead to a None valued uom_id on the product

bealdav · 2023-10-16T15:20:49Z

Thanks a lot @legalsylvain for this review.
On my side I need to port sale_quick to 16.0 then it could be a great help if we could go ahead in this current process.
Thanks both

FranzPoize · 2023-10-17T17:01:46Z

The test need odoo_test_helper==2.1.1.

And also it seems it's not possible to directly write into metadata anymore, i.e cls.product.write_uid = user_demo does not change the write_uid of the product

FranzPoize · 2023-10-17T17:14:45Z

The test need odoo_test_helper==2.1.1.

And also it seems it's not possible to directly write into metadata anymore, i.e cls.product.write_uid = user_demo does not change the write_uid of the product

It's confirmed that we can't change write_id like this anymore. This leads to this code:

        if self._log_access:
            # the superuser can set log_access fields while loading registry
            if not(self.env.uid == SUPERUSER_ID and not self.pool.ready):
                bad_names.update(LOG_ACCESS_COLUMNS)

        # set magic fields
        vals = {key: val for key, val in vals.items() if key not in bad_names}

which remove all LOG_ACCESS_COLUMNS from the written values

FranzPoize · 2023-10-17T17:30:36Z

To fix the rest of the text instead of relying on write_uid we could store the write_date and checked if it changed or not

HaraldPanten · 2023-11-29T10:34:30Z

Hi @aiendry-aktivsoftware Will you continue this PR?

THX!

legalsylvain · 2024-01-26T23:04:14Z

hi @aiendry-aktivsoftware. Friendly reminder. could you fix the CI so we can move forward ?

thanks !

github-actions · 2024-05-26T12:14:37Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

legalsylvain · 2024-05-26T12:20:49Z

Done here : #1512

Pierrick Brun and others added 30 commits July 24, 2023 15:02

[ADD] module base_product_mass_addition

a0c4247

[IMP] do not depend on arbitrary view

2193753

[IMP] make implementations intercompatible

7e3bbde

IMP ui and refactor action

9e69234

[FIX] Remove non model-agnostic filter

46f6146

[UPD] README.rst

ab8ba5b

[UPD] Update base_product_mass_addition.pot

e394391

[ADD] icon.png

6051cc6

[UPD] README.rst

590cd49

[IMP] base_product_mass_addition: black, isort

071dcf5

[MIG] base_product_mass_addition: Migration to 13.0

73061d9

[IMP] base_product_mass_addition: black, isort, prettier

d58eaae

[MIG] base_product_mass_addition: Migration to 14.0

03cfca9

[IMP] optionnaly use onchange_helper

631d087

[IMP] depend on onchange_helper

e6022ab

[UPD] Update base_product_mass_addition.pot

ae4015f

[UPD] README.rst

d5e8afc

[IMP] Add UoM functionality, simplify some code

5fde75a

[IMP] Remove purchase-specific element in function name

0ff0fa8

[IMP] Add access rights hack so that users that don't have write acce…

771dfd1

…ss to product.product may still use the feature

[IMP] Remove useless _sync_quick_lines() intermediary

f700523

[IMP] use related on quick_uom_category_id

f335e37

[REF] Remove permissions for users that cannot edit product.product. …

6700572

…TBD in another PR

[REF] Remove dead code

fdea025

[REV] Revert rename of _inverse_set_process_qty

6440da6

[UPD] Update base_product_mass_addition.pot

918cb6d

[UPD] README.rst

4bb8386

base_product_mass_addition 14.0.1.1.0

7f77ba8

Added translation using Weblate (French)

54b2c93

OCA-git-bot and others added 8 commits July 24, 2023 15:02

base_product_mass_addition 14.0.1.2.0

515f93f

[MIG]base_product_mass_addition: Migration to 15.0

665b50c

[UPD] Update base_product_mass_addition.pot

d88f9ec

[UPD] README.rst

76745c2

Added translation using Weblate (Spanish)

f25414c

[IMP] base_product_mass_addition: pre-commit stuff

9379dac

aiendry-aktivsoftware force-pushed the 16.0-mig-base_product_mass_addition branch 3 times, most recently from a34dcf0 to 186c213 Compare July 27, 2023 09:37

legalsylvain reviewed Jul 27, 2023

View reviewed changes

aiendry-aktivsoftware force-pushed the 16.0-mig-base_product_mass_addition branch from 186c213 to 3f0c81a Compare July 27, 2023 10:28

[MIG] base_product_mass_addition: Migration to 16.0

936f18a

aiendry-aktivsoftware force-pushed the 16.0-mig-base_product_mass_addition branch from 3f0c81a to 936f18a Compare July 28, 2023 08:43

bealdav reviewed Oct 16, 2023

View reviewed changes

legalsylvain reviewed Oct 16, 2023

View reviewed changes

legalsylvain mentioned this pull request Oct 17, 2023

[16.0][MIG] base_product_mass_addition : Migration to 16.0 #1434

Closed

FranzPoize mentioned this pull request Dec 21, 2023

[16.0][MIG] stock_picking_quick : Migration to 16.0 OCA/stock-logistics-workflow#1400

Merged

legalsylvain mentioned this pull request Feb 10, 2024

[16.0] MIG base_product_mass_addition #1512

Merged

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024

legalsylvain closed this May 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16.0 mig base product mass addition #1393

16.0 mig base product mass addition #1393

aiendry-aktivsoftware commented Jul 27, 2023

legalsylvain Jul 27, 2023

bealdav Oct 16, 2023 •

edited

Loading

legalsylvain Oct 16, 2023

pedrobaeza Oct 16, 2023

legalsylvain Oct 16, 2023

bealdav Oct 16, 2023

legalsylvain Oct 16, 2023

legalsylvain left a comment

legalsylvain Oct 16, 2023

legalsylvain Oct 16, 2023

legalsylvain Oct 16, 2023

legalsylvain Oct 16, 2023

FranzPoize Oct 17, 2023

FranzPoize Oct 18, 2023 •

edited

Loading

bealdav commented Oct 16, 2023 •

edited

Loading

FranzPoize commented Oct 17, 2023 •

edited

Loading

FranzPoize commented Oct 17, 2023

FranzPoize commented Oct 17, 2023

HaraldPanten commented Nov 29, 2023

legalsylvain commented Jan 26, 2024

github-actions bot commented May 26, 2024

legalsylvain commented May 26, 2024

		@@ -0,0 +1,2 @@
		Adding new implementations would be great:
		on sale.order or on stock.picking.batch for instance.

	res = super(ProductProduct, self).write(vals)
	res = super().write(vals)

16.0 mig base product mass addition #1393

16.0 mig base product mass addition #1393

Conversation

aiendry-aktivsoftware commented Jul 27, 2023

Choose a reason for hiding this comment

bealdav Oct 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

legalsylvain left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FranzPoize Oct 18, 2023 • edited Loading

Choose a reason for hiding this comment

bealdav commented Oct 16, 2023 • edited Loading

FranzPoize commented Oct 17, 2023 • edited Loading

FranzPoize commented Oct 17, 2023

FranzPoize commented Oct 17, 2023

HaraldPanten commented Nov 29, 2023

legalsylvain commented Jan 26, 2024

github-actions bot commented May 26, 2024

legalsylvain commented May 26, 2024

bealdav Oct 16, 2023 •

edited

Loading

FranzPoize Oct 18, 2023 •

edited

Loading

bealdav commented Oct 16, 2023 •

edited

Loading

FranzPoize commented Oct 17, 2023 •

edited

Loading