fix(about, project, recruitment, footer, contact): fix link to open on a new page #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
다른 페이지로 이동하는 링크들을 새 창에서 열리도록 수정했습니다.
신입회원 지원하기or모집 알림 신청하기버튼Sponsored by스폰서 목록<a>태그를 사용한 코드는target="_blank"를 추가했습니다.location.href를 사용한 코드는window.open(link)로 수정했습니다.페이지 내 이동은 현재 창에서 이동합니다.
recruitment페이지 내 버튼들이 동일하게 LinkButton을 사용하고 있어 isNewPage 변수를 추가했습니다.Issue