Merge pull request #33 from emost22/main

fix(about, project, recruitment, footer, contact): fix link to open on a new page
Nexters · Jul 13, 2023 · a9548f0 · a9548f0
2 parents 1f60a80 + 50f6de8
commit a9548f0
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 8 deletions.
diff --git a/components/about/review/card.vue b/components/about/review/card.vue
@@ -19,7 +19,7 @@ const ReviewCard = defineComponent({
   },
   methods: {
     onClick: function () {
-      window.location.href = this.href;
+      window.open(this.href);
     },
   },
 });

diff --git a/components/footer.vue b/components/footer.vue
@@ -16,7 +16,7 @@
                     :key="sponsor.idx"
                     class="sponsorItem"
                   >
-                    <a :href="sponsor.href">
+                    <a :href="sponsor.href" target="_blank">
                       <span>{{ sponsor.name }}</span>
                     </a>
                   </section>
@@ -26,7 +26,7 @@
           </div>
           <div class="sns">
             <ul v-for="item in items" v-show="item.visible" :key="item.idx">
-              <a :href="item.href">
+              <a :href="item.href" target="_blank">
                 <img :src="icon(item)" :alt="item.name" />
               </a>
             </ul>

diff --git a/components/project/project/card.vue b/components/project/project/card.vue
@@ -20,7 +20,7 @@
         @click="onClickLink(link)"
         @click.stop=""
       >
-        <a :href="link">
+        <a :href="link" target="_blank">
           {{ platform }}
         </a>
       </div>
@@ -59,7 +59,7 @@ const ProjectCard = defineComponent({
   methods: {
     ...mapActions({ showDetail: "project/showDetail" }),
     onClickLink(href) {
-      window.location.href = href;
+      window.open(href);
     },
     scrollToId(id) {
       document.getElementById(id).scrollIntoView();

diff --git a/components/project/project/detail.vue b/components/project/project/detail.vue
@@ -37,6 +37,7 @@
           :key="platform"
           class="link-item"
           :href="link"
+          target="_blank"
         >
           {{ platform }}
         </a>

diff --git a/components/recruitment/banner.vue b/components/recruitment/banner.vue
@@ -19,6 +19,7 @@
           class="box"
           :button-name="box.name"
           :href="`${box.link}`"
+          :is-new-page=true
         />
       </article>
     </div>

diff --git a/components/recruitment/linkButton.vue b/components/recruitment/linkButton.vue
@@ -26,10 +26,18 @@ export default defineComponent({
       type: String,
       require: false,
     },
+    isNewPage: {
+      type: Boolean,
+      require: true,
+    }
   },
   methods: {
     onClick: function () {
-      location.href = this.href;
+      if (this.isNewPage) {
+        window.open(this.href);
+      } else {
+        location.href = this.href;
+      }
     },
   },
 });

diff --git a/pages/contact.vue b/pages/contact.vue
@@ -72,11 +72,11 @@ export default defineComponent({
     handleClick: (action) => () => {
       switch (action) {
         case "kakao": {
-          window.location.href = "https://pf.kakao.com/_xdxmnnj";
+          window.open("https://pf.kakao.com/_xdxmnnj");
           break;
         }
         case "facebook": {
-          window.location.href = "https://www.facebook.com/Nexterspage";
+          window.open("https://www.facebook.com/Nexterspage");
           break;
         }
         case "gmail": {

diff --git a/pages/recruitment.vue b/pages/recruitment.vue
@@ -37,6 +37,7 @@
           class="faqBox"
           :button-name="`FAQ 바로가기`"
           :href="`/contact#faq`"
+          :is-new-page=false
         />
       </div>
     </div>