Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Remove on screen warning from numpy for alpha tests #1233

Merged
merged 13 commits into from
Jul 24, 2024

Conversation

RobHanna-NOAA
Copy link
Contributor

@RobHanna-NOAA RobHanna-NOAA commented Jul 23, 2024

In a PR 1217, which is about to be merged, it updates a bunch of python packages. One is numpy. This has triggered a very large amount of on-screen output from a new numpy warning while running synthesize_test_cases.py.

Must merge PR 1217 before this one.

Changes

  • tools\overlapping_inundation.py: As described

Testing

Using a docker image created from the PR 1217, made the change, then ran fim_pipeline, synth and eval against 12040101. All was well.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?
  • If applicable, has a deployment plan be created with the deployment person/team?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • n/a The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • n/a New functions are documented (with a description, list of inputs, and expected output)
  • n/a Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@RobHanna-NOAA RobHanna-NOAA self-assigned this Jul 24, 2024
@RobHanna-NOAA RobHanna-NOAA added bug Something isn't working High Priority FIM4 labels Jul 24, 2024
@RobHanna-NOAA RobHanna-NOAA marked this pull request as ready for review July 24, 2024 00:02
@RobHanna-NOAA RobHanna-NOAA requested a review from mluck July 24, 2024 00:02
mluck
mluck previously approved these changes Jul 24, 2024
Copy link
Contributor

@mluck mluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes all of the MANY warnings in #1228

@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit b662494 into dev Jul 24, 2024
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-synth-numpy branch July 24, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FIM4 High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] synthesize_test_cases.py annoying error (very large number of them)
3 participants