Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3pt] synthesize_test_cases.py annoying error (very large number of them) #1228

Closed
RobHanna-NOAA opened this issue Jul 19, 2024 · 2 comments · Fixed by #1233
Closed

[3pt] synthesize_test_cases.py annoying error (very large number of them) #1228

RobHanna-NOAA opened this issue Jul 19, 2024 · 2 comments · Fixed by #1233
Assignees
Labels
dependencies Pull requests that update a dependency file FIM4 High Priority

Comments

@RobHanna-NOAA
Copy link
Contributor

RobHanna-NOAA commented Jul 19, 2024

Soon we will merge PR 1217 with updates for OpenJDK and a bunch of python packages. One of the upgrades is for numpy.

This has triggered a new warning that creates hundreds and hundreds off on-screen messages, burying potential errors.

/foss_fim/tools/overlapping_inundation.py:399: RuntimeWarning: invalid value encountered in cast nan_tile = np.array([np.nan]).astype(dtype)[0].

I recommend we branch off of 1217 and fix this so they are merged together.

@RobHanna-NOAA RobHanna-NOAA added High Priority dependencies Pull requests that update a dependency file FIM4 labels Jul 19, 2024
@RobHanna-NOAA RobHanna-NOAA self-assigned this Jul 22, 2024
@mluck
Copy link
Contributor

mluck commented Jul 23, 2024

This seems to have originated here: numpy/numpy#21437

@RobHanna-NOAA
Copy link
Contributor Author

Needs the following fix:
Changing line 399 in tools/overlapping_inundation.py to nan_tile = np.array([np.nan]) (removed the .astype(dtype)[0] at the end)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file FIM4 High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants