Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gcc version and use Alpine 3.20 base image #979

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

kusalananda
Copy link
Member

@kusalananda kusalananda commented Aug 29, 2024

Related issue(s) and PR(s)

This PR relates to #977.

This PR should fix the automatic Docker image builds that are done by Github actions when we push to the develop branch. The issue was that the production Dockerfile tried to install a too-old version of the gcc compiler. This has been resolved, and the backend Dockerfile has been amended to use the same golang base image.

As suggested by other dependabot PRs, also bump the Go version to 1.23 while we're here.

To test:

Ensure that docker compose build succeeds in both the production subdirectory (where it fails without this PR), and in the main directory.

@kusalananda kusalananda changed the title Bump gcc version and use unversioned Alpine base image Bump gcc version and use Alpine 3.20 base image Sep 6, 2024
Copy link

@pdmnyberg pdmnyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and works as expected. I have added a comment about a warning related to previous work.

production/Dockerfile Show resolved Hide resolved
@kusalananda kusalananda merged commit 6024ab1 into develop Sep 6, 2024
12 checks passed
@kusalananda kusalananda deleted the fix-docker-builds branch September 6, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants