Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: activity name labels #888

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: activity name labels #888

merged 2 commits into from
Aug 20, 2024

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #861

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Made the activity show up in the "favourite issue" rows

Screenshot of the fix

Screenshot 2023-10-27 at 14 42 03

Testing

  • Restart urdr container
  • Check your favourite issues and make sure the label is displayed

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@KattisLej KattisLej merged commit d71ea15 into develop Aug 20, 2024
10 checks passed
@KattisLej KattisLej deleted the fix/labels-issues branch August 20, 2024 12:09
@marcelm
Copy link

marcelm commented Aug 20, 2024

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-hover text does not show activity
3 participants