fix(metrics.yaml): include new data_taxonomy & data_reviews info #86
Conversation
There was a problem hiding this comment.
@kirill-demtchouk I copied over your metrics.yaml file and then made the following changes in order for it to work on web:
-
removed
fxa_account_id,adjust_device_idandbackendcategory as these are not relevant to web -
added
bugs: TBDback to each metric as thebuild:gleanscript fails without it -
moved
baselineout ofsend_in_pingsand intono_lint- the
build:gleanscript fails if we keep as is - alternatively, web could remove
baselinealtogether
- the
-
added back
lifetime: applicationto the non-event metrics- this is what makes it so that those identifiers get sent with every ping and I have yet to figure out a different way to do this
There was a problem hiding this comment.
- Can we keep the
fxa_account_id, even if we're not using it at the moment? - What does
no_lintdo? I can't find any mention of it in the Glean docs 🙃
I think the other changes are 👌 , thank you for making them!
There was a problem hiding this comment.
Actually, can we set the bugs field to a value of https://mozilla-hub.atlassian.net/browse/MSDO-49?
There was a problem hiding this comment.
Thank you for the feedback @kirill-demtchouk! I made some changes:
- added
https://mozilla-hub.atlassian.net/browse/MSDO-49as the bugs field to all metrics - added back the
fxa_account_id - fixed a couple tiny typos (I'll call them out so you can make the changes in your metrics.yaml file as well)
The no_lint line suppresses the warning we get when running the build or lint commands. If we leave baseline as-is, we get this error:
ERROR: BASELINE_PING: identifiers.fxa_account_id: The baseline ping is Glean-internal. Remove 'baseline' from the send_in_pings array.
If you'd rather we just remove the baseline instead of classifying it as no_lint, that would be fine with me, just let me know!
There was a problem hiding this comment.
@wtfluckey Let's remove the baseline ping since it's not relevant to the Glean js SDK. I will make those typo changes on my side. Thank you for catching them!
There was a problem hiding this comment.
I'm feeling sick and will likely be offline this afternoon (and I'm out next week on PTO). Going to approve this PR to unblock you, it's not material for me to review the baseline ping change alone.
This looks good n' compliant to me 😄 Thank you for hashing out the last edits!
There was a problem hiding this comment.
Thank you for all your help @kirill-demtchouk!! Also, I hope you feel better and have an excellent thanksgiving!
There was a problem hiding this comment.
Thanks, Aly! One last thing: can we changed the "app_id" defined in the code to "moso-mastodon-web"? It's currently set to "mozilla-social-web".
telemetry/generated/web.ts
Outdated
| import EventMetricType from "@mozilla/glean/private/metrics/event"; | ||
| import StringMetricType from "@mozilla/glean/private/metrics/string"; |
There was a problem hiding this comment.
woohoo I've been ignoring this particular generated change in my local
wtfluckey
force-pushed
the
feat/glean-update-metrics.yaml
branch
from
63a39e8
to
eed66aa
Compare
| type: string | ||
| ui_additional_detail: &ui_additional_detail | ||
| description: > | ||
| An optional string to record further informatin about the UI | ||
| An optional string to record further information about the UI |
There was a problem hiding this comment.
@kirill-demtchouk - fixed a typo here
| @@ -170,13 +276,19 @@ web: | |||
| description: > | |||
| The full URL of the previous web page from which a link was followed | |||
| in order to trigger the page view. | |||
| Comes from the `referer` field of the HTTP header. | |||
| Comes from the `referrer` field of the HTTP header. | |||
There was a problem hiding this comment.
@kirill-demtchouk - one other typo here
wtfluckey
force-pushed
the
feat/glean-update-metrics.yaml
branch
from
eed66aa
to
541cbf6
Compare
|
@wtfluckey should we start sending events once this PR is merged? |
Update our
metrics.yamlfile to match the shared metrics.yaml file to include the newdata_taxonomyanddata_reviewsinformationRequesting review from Kirill as well since I made changes to the
metrics.yamlfile and we are trying to keep it as consistent as possible across clients and want to make sure that the changes I've made here don't violate our legal requirements.Completed:
bugsinfo to all metricsdata_reviewsinfo to all metricsdata_taxonomyfor all metricsfxa_account_idmetric per Kirill's request