Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Commit

Permalink
fix(metrics.yaml): add back fxa_account_id
Browse files Browse the repository at this point in the history
  • Loading branch information
wtfluckey committed Nov 17, 2023
1 parent e99affb commit eed66aa
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 7 deletions.
18 changes: 18 additions & 0 deletions telemetry/generated/identifiers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,24 @@

import StringMetricType from "@mozilla/glean/private/metrics/string";

/**
* The user's FxA account ID, if available.
* data_taxonomy:
* data_categories: [user.unique_id]
* data_uses: [analytics.reporting, personalize.content]
* data_subjects: [customer]
* data_qualifier: [identified]
*
* Generated from `identifiers.fxa_account_id`.
*/
export const fxaAccountId = new StringMetricType({
category: "identifiers",
name: "fxa_account_id",
sendInPings: ["events"],
lifetime: "ping",
disabled: false,
});

/**
* The user's full account handle, with domain. For example,
* `[email protected]`.
Expand Down
6 changes: 3 additions & 3 deletions telemetry/generated/ui.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import EventMetricType from "@mozilla/glean/private/metrics/event";

/**
* Event triggered when a user taps/clicks on a UI element, triggering a change
* in app state.
* Event triggered when a user taps/clicks on a UI element, triggering a change in
* app state.
* data_taxonomy:
* data_categories: [user.behavior]
* data_uses: [analytics.reporting, personalize.content]
Expand Down Expand Up @@ -36,7 +36,7 @@ export const engagement = new EventMetricType<{

/**
* Event triggered when a user views a notable UI element. Triggered once per page
* load, as soon as any pixel of that UI element is visible in the foreground for
* load, as soon as any pixel of that UI element is visible in the foreground for
* any length of time. UI elements may include: content, pages, CTAs, etc.
* data_taxonomy:
* data_categories: [user.behavior]
Expand Down
4 changes: 2 additions & 2 deletions telemetry/generated/web.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

// AUTOGENERATED BY glean_parser v8.1.1. DO NOT EDIT. DO NOT COMMIT.

import EventMetricType from "@mozilla/glean/private/metrics/event";
import StringMetricType from "@mozilla/glean/private/metrics/string";
import EventMetricType from "@mozilla/glean/private/metrics/event";

/**
* Event triggered when a user clicks a link on a web page.
Expand Down Expand Up @@ -67,7 +67,7 @@ export const pageView = new EventMetricType({

/**
* The full URL of the previous web page from which a link was followed in order
* to trigger the page view. Comes from the `referer` field of the HTTP header.
* to trigger the page view. Comes from the `referrer` field of the HTTP header.
* May not always be available. For example, `https://www.google.com`.
* data_taxonomy:
* data_categories: []
Expand Down
26 changes: 24 additions & 2 deletions telemetry/metrics.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,28 @@
$schema: moz://mozilla.org/schemas/glean/metrics/2-0-0

identifiers:
fxa_account_id: # not used by web, but requested by Kirill to keep in here
type: string
description: >
The user's FxA account ID, if available.
data_taxonomy:
data_categories: [user.unique_id]
data_uses: [analytics.reporting, personalize.content]
data_subjects: [customer]
data_qualifier: [identified]
bugs:
- https://mozilla-hub.atlassian.net/browse/MSDO-49
data_reviews:
- https://docs.google.com/document/d/17vK3r7Sihb_S4-_8oKNoAraWeb_QiomC3UL-2W7PHgY/edit?usp=sharing
notification_emails:
- [email protected]
expires: never
send_in_pings:
- events
no_lint:
- baseline

mastodon_account_id:
type: string
lifetime: application
Expand Down Expand Up @@ -109,7 +131,7 @@ ui:
type: string
ui_additional_detail: &ui_additional_detail
description: >
An optional string to record further informatin about the UI
An optional string to record further information about the UI
element, such as its starting value if it is a toggle or setting.
data_taxonomy:
Expand Down Expand Up @@ -254,7 +276,7 @@ web:
description: >
The full URL of the previous web page from which a link was followed
in order to trigger the page view.
Comes from the `referer` field of the HTTP header.
Comes from the `referrer` field of the HTTP header.
May not always be available.
For example, `https://www.google.com`.
Expand Down

0 comments on commit eed66aa

Please sign in to comment.