Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: also mention GitHub apps in creation #693

Merged
merged 3 commits into from
Aug 23, 2023
Merged

chore: also mention GitHub apps in creation #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08bab96
fix: use Vitest's default coverage provider (v8)
JoshuaKGoldberg Aug 23, 2023
67d73d4
Also update setup files
JoshuaKGoldberg Aug 23, 2023
92828cc
Updated snapshot
JoshuaKGoldberg Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"@types/prettier": "^2.7.3",
"@typescript-eslint/eslint-plugin": "^6.4.0",
"@typescript-eslint/parser": "^6.4.0",
"@vitest/coverage-istanbul": "^0.34.2",
"@vitest/coverage-v8": "^0.34.2",
"all-contributors-cli": "^6.26.1",
"c8": "^8.0.1",
"console-fail-test": "^0.2.3",
Expand Down
177 changes: 12 additions & 165 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/steps/finalizeDependencies.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe("finalize", () => {
expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
[
[
"pnpm add @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest all-contributors-cli@latest cspell@latest eslint@latest eslint-config-prettier@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-import@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest npm-package-json-lint@latest npm-package-json-lint-config-default@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest sentences-per-line@latest should-semantic-release@latest tsup@latest typescript@latest yaml-eslint-parser@latest release-it@latest @vitest/coverage-istanbul@latest console-fail-test@latest eslint-plugin-no-only-tests@latest eslint-plugin-vitest@latest vitest@latest -D",
"pnpm add @types/eslint@latest @typescript-eslint/eslint-plugin@latest @typescript-eslint/parser@latest all-contributors-cli@latest cspell@latest eslint@latest eslint-config-prettier@latest eslint-plugin-deprecation@latest eslint-plugin-eslint-comments@latest eslint-plugin-import@latest eslint-plugin-jsdoc@latest eslint-plugin-jsonc@latest eslint-plugin-markdown@latest eslint-plugin-n@latest eslint-plugin-perfectionist@latest eslint-plugin-regexp@latest eslint-plugin-yml@latest husky@latest jsonc-eslint-parser@latest knip@latest lint-staged@latest markdownlint@latest markdownlint-cli@latest npm-package-json-lint@latest npm-package-json-lint-config-default@latest prettier@latest prettier-plugin-curly@latest prettier-plugin-packagejson@latest sentences-per-line@latest should-semantic-release@latest tsup@latest typescript@latest yaml-eslint-parser@latest release-it@latest @vitest/coverage-v8@latest console-fail-test@latest eslint-plugin-no-only-tests@latest eslint-plugin-vitest@latest vitest@latest -D",
],
[
"npx all-contributors-cli generate",
Expand Down
2 changes: 1 addition & 1 deletion src/steps/finalizeDependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export async function finalizeDependencies({

if (unitTests) {
devDependencies.push(
"@vitest/coverage-istanbul",
"@vitest/coverage-v8",
"console-fail-test",
"eslint-plugin-no-only-tests",
"eslint-plugin-vitest",
Expand Down
1 change: 0 additions & 1 deletion src/steps/writing/creation/rootFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,6 @@ export default defineConfig({
all: true,
exclude: ["lib"],
include: ["src"],
provider: "istanbul",
reporter: ["html", "lcov"],
},
exclude: ["lib", "node_modules"],
Expand Down
1 change: 0 additions & 1 deletion vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export default defineConfig({
all: true,
exclude: ["lib"],
include: ["src"],
provider: "istanbul",
reporter: ["html", "lcov"],
},
exclude: ["lib", "node_modules"],
Expand Down