Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: also mention GitHub apps in creation #693

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 23, 2023

PR Checklist

Overview

Skips using istanbul, in favor of v8. I'm hoping using the same coverage report format will help Codecov figure things out. Note that this now triggers vitest-dev/vitest#3605 issue of v8 counting types as untested.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #693 (92828cc) into main (be72601) will increase coverage by 6.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   89.03%   95.22%   +6.18%     
==========================================
  Files          78       82       +4     
  Lines        3695     3730      +35     
  Branches      145      173      +28     
==========================================
+ Hits         3290     3552     +262     
+ Misses        400      178     -222     
+ Partials        5        0       -5     
Flag Coverage Δ
create 73.81% <100.00%> (-0.01%) ⬇️
initialize 35.35% <0.00%> (+<0.01%) ⬆️
migrate 75.29% <0.00%> (-0.01%) ⬇️
unit 39.07% <100.00%> (-22.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/writing/creation/rootFiles.ts 94.93% <ø> (-2.23%) ⬇️
src/steps/finalizeDependencies.ts 100.00% <100.00%> (ø)

... and 40 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit a944257 into main Aug 23, 2023
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the coverage-with-v8 branch August 23, 2023 08:08
@github-actions
Copy link

🎉 This is included in version v1.29.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Code coverage is underreported?
1 participant