-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: AddressDetailExplorer to fn component #317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4mmer
reviewed
Sep 17, 2024
alexruzenhack
previously approved these changes
Sep 17, 2024
tuliomir
force-pushed
the
refactor/address-detail-fn
branch
from
October 16, 2024 14:34
0ecf5cb
to
f979f47
Compare
alexruzenhack
approved these changes
Oct 16, 2024
r4mmer
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Motivation
This component used the deprecated
withRouter
connector, which will become unavailable in the coming upgrade to React Router v6.In order to remove its usage, it was necessary to refactor it to use react hooks as a functional component. This proved to be harder than initially foreseen because the code relied heavily upon async state setters, a feature that is also no longer available with
useState()
hooks.So, instead of setting the state, waiting for it to be rendered and then applying the next set of instructions, the code now sets the state and then a
useEffect()
handles its change. Many data flow reorganizations were made to achieve this new structure.Note for the reviewers
Since this component is so complex and had deep changes to its data flow, I'd recommend checking the before and after versions of the code to understand the changes made.
Security Checklist