Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Address detail params #320

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix: Address detail params #320

merged 1 commit into from
Sep 17, 2024

Conversation

tuliomir
Copy link
Contributor

A similar quick-fix as the one made by #316, this is a quick fix that precedes the refactoring that will be implemented by #317 and #319

Acceptance Criteria

  • The children of the AddressDetail screen should receive the correct parameters

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label Sep 17, 2024
@tuliomir tuliomir self-assigned this Sep 17, 2024
@tuliomir tuliomir removed the request for review from r4mmer September 17, 2024 12:52
@tuliomir tuliomir merged commit 8391ac6 into dev Sep 17, 2024
1 check passed
@tuliomir tuliomir deleted the fix/address-detail-params branch September 17, 2024 13:30
@tuliomir tuliomir mentioned this pull request Sep 17, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@tuliomir tuliomir

Labels
bug Something isn't working
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliomir @pedroferreira1 @andreabadesso