Expose initialization mode #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but we should probably merge in #42 to silence the warnings for this patch. I'll rebase your change once that is in. |
nilfit
previously requested changes
Oct 21, 2023
|
👍🏻 |
Added initialization_mode method to DynAux trait, to enable software support for disabling of the CAN bus.
Add PR number to the changelog Co-authored-by: Nils Fitinghoff <[email protected]>
Ironedde
force-pushed
the
expose_init_mode
branch
from
7ca71f2
to
d5ece01
Compare
|
I rebased the branch, the clippy test should now pass. |
Ironedde
dismissed
nilfit’s stale review
Reference has been added to the changelog.
epontan
approved these changes
Oct 24, 2023
Ironedde
pushed a commit
to Ironedde/mcan-clone
that referenced
this pull request
Oct 24, 2023
- Added - Add `Can::aux::initialization_mode` (GrepitAB#41) - Changed - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43) - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
Merged
Ironedde
pushed a commit
to Ironedde/mcan-clone
that referenced
this pull request
Oct 24, 2023
- Added - Add `Can::aux::initialization_mode` (GrepitAB#41) - Changed - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43) - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
Ironedde
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initialization_mode method to DynAux trait, to enable software support for disabling of the CAN bus.
Created a new method initialization_mode in reg, similar to configuration_mode but without setting the configuration bit. While CCCR.INIT is set, message transfer from and to the CAN bus is stopped. Setting CCCR.INIT does not change any configuration register.
Exposed the initialization mode by adding the initialization_mode function to the DynAux trait, with will implement a call to the initialization_mode method in reg.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo +stable fmtwas run.cargo +stable clippyyields nowarnings.CHANGELOG.mdin the proper section.newly added features and code.