-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose initialization mode #41
Conversation
LGTM, but we should probably merge in #42 to silence the warnings for this patch. I'll rebase your change once that is in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good addtion, thanks!
👍🏻 |
Added initialization_mode method to DynAux trait, to enable software support for disabling of the CAN bus.
Add PR number to the changelog Co-authored-by: Nils Fitinghoff <[email protected]>
7ca71f2
to
d5ece01
Compare
I rebased the branch, the clippy test should now pass. |
Reference has been added to the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and ready 👍
- Added - Add `Can::aux::initialization_mode` (GrepitAB#41) - Changed - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43) - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
- Added - Add `Can::aux::initialization_mode` (GrepitAB#41) - Changed - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43) - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
Added initialization_mode method to DynAux trait, to enable software support for disabling of the CAN bus.
Created a new method initialization_mode in reg, similar to configuration_mode but without setting the configuration bit. While CCCR.INIT is set, message transfer from and to the CAN bus is stopped. Setting CCCR.INIT does not change any configuration register.
Exposed the initialization mode by adding the initialization_mode function to the DynAux trait, with will implement a call to the initialization_mode method in reg.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errors
orwarnings
.cargo +stable fmt
was run.cargo +stable clippy
yields nowarnings
.CHANGELOG.md
in the proper section.newly added features and code.