Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release mcan/0.4.0 #44

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Release mcan/0.4.0 #44

merged 1 commit into from
Oct 24, 2023

Conversation

Ironedde
Copy link
Contributor

Added

Changed

@Ironedde Ironedde requested a review from a team as a code owner October 24, 2023 12:59
@Ironedde
Copy link
Contributor Author

Ironedde commented Oct 24, 2023

TODO after merge:

  • Add tag mcan/0.4.0 to the master branch
  • Publish to crates.io

- Adhere to `filter_map_bool_then` clippy lint (#42)


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this redundant empty newline. There is only one line difference between the versions, if you compare against 0.2.0 and 0.3.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, must have copied one line to much when moving from Unreleased section.
Fixed it 👍

Copy link
Collaborator

@epontan epontan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor nit in the changelog.

- Added
 - Add `Can::aux::initialization_mode` (GrepitAB#41)

- Changed
 - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43)
 - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
Copy link
Collaborator

@epontan epontan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ironedde Ironedde merged commit b390833 into GrepitAB:master Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants