Fix json pre commit errors inside the repo #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serdardalgic
force-pushed
the
fix-pre-commit-ci-errors-inside-the-repo
branch
from
2bd29c5
to
5e51754
Compare
drsm79
previously approved these changes
Nov 14, 2022
serdardalgic
force-pushed
the
conventional-commit-checker-GH-action
branch
from
38e5308
to
5745edd
Compare
Base automatically changed from
conventional-commit-checker-GH-action
to
main
November 15, 2022 13:45
for more information, see https://pre-commit.ci
This launch.json file is an autogenerated vscode-go file. VSCode uses Json with Comments(jsonc) mode for its configuration files. If we can find a way to introduce jsonc check to our pre-commit hooks, we can change back the format of this file. To read more about JsonC: https://code.visualstudio.com/docs/languages/json#_json-with-comments There is also an extension to JSON called Json5, Json for Humans. https://json5.org/ Json5 formatter/checkers can be replaced with Json later.
serdardalgic
force-pushed
the
fix-pre-commit-ci-errors-inside-the-repo
branch
from
5e51754
to
796cdf9
Compare
|
I'm closing this PR in favor of #79. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the pre-commit checker errors for json files.
The launch.json file is an autogenerated vscode-go file. VSCode uses Json with Comments(jsonc) mode for its configuration files.
If we can find a way to introduce jsonc check to our pre-commit hooks, we can change back the format of this file.
To read more about JsonC:
https://code.visualstudio.com/docs/languages/json#_json-with-comments
There is also an extension to JSON called Json5, Json for Humans. https://json5.org/ However, according to their website:
Please review.