Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VsCode Json files and pre-commit json check clash #79

Open
serdardalgic opened this issue Nov 22, 2022 · 0 comments
Open

Fix VsCode Json files and pre-commit json check clash #79

serdardalgic opened this issue Nov 22, 2022 · 0 comments
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@serdardalgic
Copy link
Contributor

Now we have .vscode/launch.json and terraform-registry-manifest.json files that do not comply with our pre-commit JSON checks, namely check-json and pretty-format.json.

Those files are exactly the same in the terraform-provider-scaffolding repository. And I think there is not much value in fixing their style for now.

The launch.json file is a JSONC, an extension of JSON that allows comments.
We can investigate if there is a way to check JSONC files with another pre-commit hook and exclude it from the JSON files.

Long story short:

  • Our JSON pre-commit checks are failing for 2 files
  • It errors in the pre-commit check only when those two files are changed, or pre-commit run --all-files are run. It's not a blocker for merging the PRs because of the pre-commit check.
  • We either need to exclude those two from the JSON checks or find adequate pre-commit checks that would target the Jsonc.

In any case, this issue is trivial. Just writing it to document the current status.

Related: #51

@serdardalgic serdardalgic added the github_actions Pull requests that update GitHub Actions code label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

1 participant