You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The launch.json file is a JSONC, an extension of JSON that allows comments.
We can investigate if there is a way to check JSONC files with another pre-commit hook and exclude it from the JSON files.
Long story short:
Our JSON pre-commit checks are failing for 2 files
It errors in the pre-commit check only when those two files are changed, or pre-commit run --all-files are run. It's not a blocker for merging the PRs because of the pre-commit check.
We either need to exclude those two from the JSON checks or find adequate pre-commit checks that would target the Jsonc.
In any case, this issue is trivial. Just writing it to document the current status.
Now we have .vscode/launch.json and terraform-registry-manifest.json files that do not comply with our pre-commit JSON checks, namely check-json and pretty-format.json.
Those files are exactly the same in the terraform-provider-scaffolding repository. And I think there is not much value in fixing their style for now.
The launch.json file is a JSONC, an extension of JSON that allows comments.
We can investigate if there is a way to check JSONC files with another pre-commit hook and exclude it from the JSON files.
Long story short:
pre-commit run --all-files
are run. It's not a blocker for merging the PRs because of the pre-commit check.In any case, this issue is trivial. Just writing it to document the current status.
Related: #51
The text was updated successfully, but these errors were encountered: