-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mbarba/brc mode #180
Mbarba/brc mode #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, couple of minor changes.
Two comments (not affecting the approval in any way):
- I fear how this is going to be merged with PR#173 (there are places that have been changed in both)
- I'm wondering if there is something similar than the parametrize in pytest for the Nextflow tests to avoid reflecting information such as
_brc_mode_of
in the name...
Co-authored-by: J. Alvarez-Jarreta <[email protected]>
Rebase/merges make it pretty easy to resolve conflicts along the way. We just need to make sure that the tests work in the end.
Some of the files contents should actually differ, so we do need that distinction. I don't intend to add other variations though. |
Clean up brc_mode usage: