Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mbarba/brc mode #180

Merged
merged 12 commits into from
Nov 2, 2023
Merged

Mbarba/brc mode #180

merged 12 commits into from
Nov 2, 2023

Conversation

MatBarba
Copy link
Contributor

Clean up brc_mode usage:

  • define as 0 by default in all pipelines
  • remove from scripts where it is not used
  • use params.brc_mode universally
  • add some basic pipeline tests

Copy link
Contributor

@JAlvarezJarreta JAlvarezJarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, couple of minor changes.

Two comments (not affecting the approval in any way):

  • I fear how this is going to be merged with PR#173 (there are places that have been changed in both)
  • I'm wondering if there is something similar than the parametrize in pytest for the Nextflow tests to avoid reflecting information such as _brc_mode_of in the name...

@MatBarba
Copy link
Contributor Author

MatBarba commented Nov 1, 2023

Looks great, couple of minor changes.

Two comments (not affecting the approval in any way):

* I fear how this is going to be merged with PR#173 (there are places that have been changed in both)

Rebase/merges make it pretty easy to resolve conflicts along the way. We just need to make sure that the tests work in the end.

* I'm wondering if there is something similar than the parametrize in pytest for the Nextflow tests to avoid reflecting information such as `_brc_mode_of` in the name...

Some of the files contents should actually differ, so we do need that distinction. I don't intend to add other variations though.

@MatBarba MatBarba merged commit 7ea21fa into main Nov 2, 2023
1 check passed
@MatBarba MatBarba deleted the mbarba/brc_mode branch November 2, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants