Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#6367: Insert FILTER_ENDPOINT when going to TRACE from COUNT also. #6368

Merged
merged 8 commits into from
Oct 20, 2023
Merged

i#6367: Insert FILTER_ENDPOINT when going to TRACE from COUNT also. #6368

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5691f9b
i6367: Insert FILTER_ENDPOINT when going to TRACE from COUNT also.
prasun3 Oct 13, 2023
f6d09bc
Merge branch 'master' into i6367-filter_endpoint-fix
prasun3 Oct 16, 2023
225fb89
i6367: Fixed test failures
prasun3 Oct 16, 2023
455e55f
Merge branch 'master' into i6367-filter_endpoint-fix
prasun3 Oct 17, 2023
4917089
i#6367: Changed condition check to assert
prasun3 Oct 18, 2023
0c3d2d0
Merge branch 'master' into i6367-filter_endpoint-fix
prasun3 Oct 18, 2023
3204fdc
Merge branch 'master' into i6367-filter_endpoint-fix
prasun3 Oct 19, 2023
ba92b4c
Merge branch 'master' into i6367-filter_endpoint-fix
prasun3 Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clients/drcachesim/tracer/output.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,9 +1099,14 @@ process_and_output_buffer(void *drcontext, bool skip_size_cap)
}
// Switch to instruction-tracing mode by adding FILTER_ENDPOINT marker if another
prasun3 marked this conversation as resolved.
Show resolved Hide resolved
prasun3 marked this conversation as resolved.
Show resolved Hide resolved
// thread triggered the switch.
ptr_int_t local_mode = get_local_mode(data);
ptr_int_t mode = tracing_mode.load(std::memory_order_acquire);
if (get_local_mode(data) != mode) {
if (get_local_mode(data) == BBDUP_MODE_L0_FILTER) {
if (op_L0_filter_until_instrs.get_value() && mode == BBDUP_MODE_TRACE) {
// It is possible that the local mode was COUNT, but tracing_mode changed
// to L0_FILTER and then to TRACE.
DR_ASSERT(local_mode == BBDUP_MODE_COUNT ||
local_mode == BBDUP_MODE_L0_FILTER);
NOTIFY(0, "Thread %d: filter mode changed\n", dr_get_thread_id(drcontext));

// If a switch occurred, then it is possible that the buffer
Expand Down
Loading