-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#6367: Insert FILTER_ENDPOINT when going to TRACE from COUNT also. #6368
Conversation
Added check for L0_filter_until_instrs since the new condition might apply to other cases as well Issue: #6367
The aarch64 failures seem related to this feature but I have no idea why this would fail only for aarch64. The 'x86-64-ubuntu22' failure is |
In general, please look at the failure reason and cite the issue number. Looks like failure to synchronize #6185 which nobody seems able to reproduce locally to try to fix. |
x86-64 failed with #6185 again |
x86-64-ubuntu22 failed with #6185 again |
x86-32 failed with #6303
|
For BIMODAL traces (see #5199), the normal transition is from COUNT to L0_FILTER to TRACE. But some threads may transition from COUNT to TRACE directly e.g., if they were not scheduled during L0_FILTER mode. In this case, the FILTER_ENDPOINT marker is not inserted currently, which leads to raw2trace failures.
An example cmd line that reproduces the bug is shown below. Note that there is only one worker thread which transitions through L0_FILTER and TRACE mode while the main thread is still in COUNT mode.
Issue: #6367