Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Flexibility and Simplify Ingress Management - GKE deployment #13

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

pawelmrowka
Copy link
Contributor

  • Annotation Support for Services: Both the API Server and Frontend services can now have annotations added through chart values, enhancing deployment flexibility.

  • Support for Tolerations: Added tolerations support for both the API server and the frontend, allowing pods to be scheduled on nodes with matching taints.

  • Security Context for the API Server: Introduced a securityContext configuration with fsGroup and fsGroupChangePolicy settings for the API server deployment. This change is crucial for enabling write access to persistent storage by adjusting file system permissions, ensuring the application can correctly handle data persistence.

  • Unified Ingress Configuration: Simplified ingress handling by consolidating ingress resources into a single domain/configuration that includes rules for both the API and the frontend, improving manageability and configuration clarity.
    Removal of Separate Ingress for Frontend: The individual ingress resource for the frontend has been removed, indicating a move towards using a unified ingress approach.

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pawelmrowka! Minor question regarding the fsGroup.

pawelmrowka and others added 3 commits April 12, 2024 09:35
* Update helm-release.yml

Signed-off-by: pawelmrowka <[email protected]>

* Update helm-release.yml

Signed-off-by: pawelmrowka <[email protected]>

* ✨ add support for tolerations, fix permissions for /data persistentstorage

* 🚀 support for service annotations

* 🐛 fix service annotations

* 🍻 service annotations for apiServer

* 🍻 values.yaml updated

* 🍻 global ingress

* 🍻 global ingress

* 🍻 global ingress

* 🍻 iterate over paths

* 🍻 iterate over paths

* 🍻 extracontainers separation + ingress cleanup

* 🍻 chart version bump

* Update helm docs

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* ✨ allow to use initContainers, provide example for fix-permission container

* ⬆️ version bump

* Update helm docs

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: pawelmrowka <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dawid Linke <[email protected]>
Co-authored-by: dawidolespl <[email protected]>
Signed-off-by: Pawel Mrowka <[email protected]>
@nscuro nscuro added the enhancement New feature or request label Apr 12, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pawelmrowka! 🚀

@nscuro nscuro merged commit 4264360 into DependencyTrack:main Apr 12, 2024
4 checks passed
@pawelmrowka pawelmrowka deleted the merge branch April 15, 2024 09:52
nscuro added a commit that referenced this pull request Jun 12, 2024
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <[email protected]>
Co-authored-by: Edvin Norling <[email protected]>
Co-authored-by: Jaz Ark <[email protected]>
Co-authored-by: Arnaud Hatzenbuhler <[email protected]>
Co-authored-by: Stefan Hynek <[email protected]>
Co-authored-by: Theodor van Nahl <[email protected]>
Co-authored-by: Sergiy Kulanov <[email protected]>
Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Jun 12, 2024
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <[email protected]>
Co-authored-by: Edvin Norling <[email protected]>
Co-authored-by: Jaz Ark <[email protected]>
Co-authored-by: Arnaud Hatzenbuhler <[email protected]>
Co-authored-by: Stefan Hynek <[email protected]>
Co-authored-by: Theodor van Nahl <[email protected]>
Co-authored-by: Sergiy Kulanov <[email protected]>
Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Jun 12, 2024
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Co-authored-by: Pawel Mrowka <[email protected]>
Co-authored-by: Edvin Norling <[email protected]>
Co-authored-by: Jaz Ark <[email protected]>
Co-authored-by: Arnaud Hatzenbuhler <[email protected]>
Co-authored-by: Stefan Hynek <[email protected]>
Co-authored-by: Theodor van Nahl <[email protected]>
Co-authored-by: Sergiy Kulanov <[email protected]>
Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Jun 12, 2024
Includes changes from:

* #13
* #22
* #23
* #33
* #34
* #42
* #52
* #55
* #57
* #83
* #87

Signed-off-by: nscuro <[email protected]>
Co-authored-by: Pawel Mrowka <[email protected]>
Co-authored-by: Edvin Norling <[email protected]>
Co-authored-by: Jaz Ark <[email protected]>
Co-authored-by: Arnaud Hatzenbuhler <[email protected]>
Co-authored-by: Stefan Hynek <[email protected]>
Co-authored-by: Theodor van Nahl <[email protected]>
Co-authored-by: Sergiy Kulanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants