-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment Flexibility and Simplify Ingress Management - GKE deployment #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pawelmrowka! Minor question regarding the fsGroup
.
* Update helm-release.yml Signed-off-by: pawelmrowka <[email protected]> * Update helm-release.yml Signed-off-by: pawelmrowka <[email protected]> * ✨ add support for tolerations, fix permissions for /data persistentstorage * 🚀 support for service annotations * 🐛 fix service annotations * 🍻 service annotations for apiServer * 🍻 values.yaml updated * 🍻 global ingress * 🍻 global ingress * 🍻 global ingress * 🍻 iterate over paths * 🍻 iterate over paths * 🍻 extracontainers separation + ingress cleanup * 🍻 chart version bump * Update helm docs Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * ✨ allow to use initContainers, provide example for fix-permission container * ⬆️ version bump * Update helm docs Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: pawelmrowka <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dawid Linke <[email protected]> Co-authored-by: dawidolespl <[email protected]>
Signed-off-by: Pawel Mrowka <[email protected]>
Signed-off-by: Pawel Mrowka <[email protected]>
nscuro
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pawelmrowka! 🚀
nscuro
added a commit
that referenced
this pull request
Jun 12, 2024
Includes changes from: * #13 * #22 * #23 * #33 * #34 * #42 * #52 * #55 * #57 * #83 * #87 Co-authored-by: Pawel Mrowka <[email protected]> Co-authored-by: Edvin Norling <[email protected]> Co-authored-by: Jaz Ark <[email protected]> Co-authored-by: Arnaud Hatzenbuhler <[email protected]> Co-authored-by: Stefan Hynek <[email protected]> Co-authored-by: Theodor van Nahl <[email protected]> Co-authored-by: Sergiy Kulanov <[email protected]> Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Jun 12, 2024
Includes changes from: * #13 * #22 * #23 * #33 * #34 * #42 * #52 * #55 * #57 * #83 * #87 Co-authored-by: Pawel Mrowka <[email protected]> Co-authored-by: Edvin Norling <[email protected]> Co-authored-by: Jaz Ark <[email protected]> Co-authored-by: Arnaud Hatzenbuhler <[email protected]> Co-authored-by: Stefan Hynek <[email protected]> Co-authored-by: Theodor van Nahl <[email protected]> Co-authored-by: Sergiy Kulanov <[email protected]> Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Jun 12, 2024
Includes changes from: * #13 * #22 * #23 * #33 * #34 * #42 * #52 * #55 * #57 * #83 * #87 Co-authored-by: Pawel Mrowka <[email protected]> Co-authored-by: Edvin Norling <[email protected]> Co-authored-by: Jaz Ark <[email protected]> Co-authored-by: Arnaud Hatzenbuhler <[email protected]> Co-authored-by: Stefan Hynek <[email protected]> Co-authored-by: Theodor van Nahl <[email protected]> Co-authored-by: Sergiy Kulanov <[email protected]> Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Jun 12, 2024
Includes changes from: * #13 * #22 * #23 * #33 * #34 * #42 * #52 * #55 * #57 * #83 * #87 Signed-off-by: nscuro <[email protected]> Co-authored-by: Pawel Mrowka <[email protected]> Co-authored-by: Edvin Norling <[email protected]> Co-authored-by: Jaz Ark <[email protected]> Co-authored-by: Arnaud Hatzenbuhler <[email protected]> Co-authored-by: Stefan Hynek <[email protected]> Co-authored-by: Theodor van Nahl <[email protected]> Co-authored-by: Sergiy Kulanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotation Support for Services: Both the API Server and Frontend services can now have annotations added through chart values, enhancing deployment flexibility.
Support for Tolerations: Added tolerations support for both the API server and the frontend, allowing pods to be scheduled on nodes with matching taints.
Security Context for the API Server: Introduced a securityContext configuration with fsGroup and fsGroupChangePolicy settings for the API server deployment. This change is crucial for enabling write access to persistent storage by adjusting file system permissions, ensuring the application can correctly handle data persistence.
Unified Ingress Configuration: Simplified ingress handling by consolidating ingress resources into a single domain/configuration that includes rules for both the API and the frontend, improving manageability and configuration clarity.
Removal of Separate Ingress for Frontend: The individual ingress resource for the frontend has been removed, indicating a move towards using a unified ingress approach.