Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default podSecurityContext to fix /data volume permissions #123

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

arteonprifti
Copy link
Contributor

@arteonprifti arteonprifti commented Jul 26, 2024

@nscuro
Copy link
Member

nscuro commented Jul 26, 2024

Thanks for the PR @arteonprifti!

Unfortunately, this won't work with OpenShift. So it's probably best to wrap the securityContext in an if or with template block to highlight it being optional.

Perhaps also add a comment in values.yaml that points out that it will need to be set to null explicitly for OpenShift.

@nscuro nscuro added the enhancement New feature or request label Jul 26, 2024
Signed-off-by: Arteon Prifti <[email protected]>
@arteonprifti
Copy link
Contributor Author

@nscuro updated as required

@nscuro
Copy link
Member

nscuro commented Jul 31, 2024

Marking as breaking change because OpenShift users will need to explicitly unset the new value.

@nscuro nscuro changed the title Add podSecurityContext to fix /data volume permissions Add default podSecurityContext to fix /data volume permissions Jul 31, 2024
@nscuro nscuro merged commit 9ea8948 into DependencyTrack:main Jul 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants