[v8r0] Drop TS permission check for all read-only functions #7199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
chrisburr
approved these changes
Sep 14, 2023
fstagni
approved these changes
Sep 14, 2023
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Sep 14, 2023
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/6184360864 Successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We got a bit carried away with the permissions checks and added them to some of the read-only functions, which breaks some things. This patch removes the checks from all of the get* functions.
I think this one should sweep OK as the changes needed in integration are identical.
Regards,
Simon
Fixes #7198 .
BEGINRELEASENOTES
*TransformationSystem
FIX: Drop TS permission check for all read-only functions
ENDRELEASENOTES