Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New permissions in the transformation system #7198

Closed
chrisburr opened this issue Sep 14, 2023 · 3 comments · Fixed by #7199
Closed

New permissions in the transformation system #7198

chrisburr opened this issue Sep 14, 2023 · 3 comments · Fixed by #7199
Assignees

Comments

@chrisburr
Copy link
Member

In #7113 access to TransformationClient.getTransformation was restricted however access to TransformationClient.getTransformations was not.

Though in the actual method, it seems at a glance that getTransformation is just an wrapper around getTransformations so it's not clear to me why they wouldn't be treated the same way:

def getTransformation(self, transName, extraParams=False, connection=False):
"""Get Transformation definition and parameters of Transformation identified by TransformationID"""
res = self._getConnectionTransID(connection, transName)
if not res["OK"]:
return res
connection = res["Value"]["Connection"]
transID = res["Value"]["TransformationID"]
res = self.getTransformations(
condDict={"TransformationID": transID}, extraParams=extraParams, connection=connection
)

It's the same for getTransformationParameters.

The WebApp also now silently fails due to accessing these methods as well as getTransformationStats, getTransformationFilesCount and potentially more.

I guess more importantly the original PR stated:

we decided that we'll be fine with people seeing other transformations - just not modifying them.

but in practice the change restricts large parts of the "seeing other transfromations". This is somewhat pressing as LHCbDIRAC extensively relies on users having read access to all transformations.

@marianne013
Copy link
Contributor

Tagging @sfayer
We'll have a look.

@marianne013
Copy link
Contributor

@chrisburr What permissions (of any) do these users have ?

@chaen
Copy link
Contributor

chaen commented Sep 14, 2023

They have

      Properties = NormalUser
      Properties += PrivateLimitedDelegation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants